Skip to content

Enhance tab button accessibility attributes #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianteeman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance tab button accessibility attributes #266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5fd634
Enhance tab button accessibility attributes
brianteeman Oct 26, 2026
2981a6b
Fix tab ID attribute setting in tab.js
brianteeman Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/js/tab/tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,14 @@ class TabsElement extends HTMLElement {

// Create tab button
const tabButton = document.createElement('button');
tabButton.setAttribute('id', `${tab.id}-tab`);
Comment thread
brianteeman marked this conversation as resolved.
Resolved
tabButton.setAttribute('aria-selected', !!tab.hasAttribute('active'));
tabButton.setAttribute('aria-controls', tab.id);
tabButton.setAttribute('role', 'tab');
tabButton.setAttribute('type', 'button');
tabButton.setAttribute('tabindex', -1);
tabButton.innerHTML = `${tab.getAttribute('name')}`;
tab.setAttribute('aria-labelledby', tabButton.id);

if (tab.hasAttribute('active')) {
tabButton.setAttribute('tabindex', 0);
Expand Down Expand Up @@ -330,6 +332,8 @@ class TabsElement extends HTMLElement {

// Create tab button
const tabButton = document.createElement('button');
tabButton.setAttribute('id', `${tab.id}-tab`);
tab.setAttribute('aria-labelledby', tabButton.id);
tabButton.setAttribute('aria-expanded', !!tab.hasAttribute('active'));
tabButton.setAttribute('aria-controls', tab.id);
tabButton.setAttribute('role', 'tab');
Expand Down
Loading