Skip to content

Enhance tab button accessibility attributes - #266

Open
brianteeman wants to merge 2 commits into
joomla-projects:masterfrom
brianteeman:patch-1
Open

brianteeman wants to merge 2 commits into
joomla-projects:masterfrom
brianteeman:patch-1

Conversation

@brianteeman

Copy link
Copy Markdown
Contributor

Pull Request for Issue #

Summary of Changes

Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

This is solved by adding 'id' and 'aria-labelledby' attributes to tab buttons for better accessibility.

Before this PR the generated code looks like this

<joomla-tab-element
    role="tabpanel"
    name="General"
    active=""
    id="general"
    class="test">

After the PR the generated code includes aria-labbeledby="xx" where "xx" is the newly added id on the button

Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

This is solved by adding 'id' and 'aria-labelledby' attributes to tab buttons for better accessibility.
Comment thread src/js/tab/tab.js Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants