Use int as address for in-memory report - #493
Merged
Merged
Conversation
jonschz
approved these changes
Jul 25, 2026
jonschz
left a comment
jonschz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I also didn't find any regression when trying reccmp-reccmp --json and reccmp-reccmp --diff, though I didn't test a lot of scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON and HTML report files expect a hex string for each address. We also use this to print to the terminal.
Instead of converting the
intaddress when the in-memory report is created, delay this until we need to write a file or display something. (In the spirit of #307.)The sticking point is the magic string
"various"that appears for the recomp addr when the entity is created byreccmp-aggregate. We have a new property for this to distinguish between the recomp addr beingNonebecause this is an unmatched entity or because it is matched but has no fixed recomp address. We don't currently use the report to hold unmatched entities, but I want to do this in a follow-up to fix some gaps with accuracy/progress calculation. (See: #444 and #447.)We did not have any tests specific to the version 1 report format, so I added some.