Use report for progress calculation - #486
Open
disinvite wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
After some thought, this is too big to comfortably review. Let's start with #493 then rebase this one. |
This was referenced Jul 25, 2026
Merged
…n in report_progress_stats.
disinvite
marked this pull request as ready for review
July 26, 2026 21:43
Collaborator
Author
|
The function total now embedded in the report should help finish up #450. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the following changes to
ReccmpStatusReportand its child structReccmpComparedEntity:The report created by
reccmp-reccmpnow contains both matched and unmatched entities. The reason is so we can use the contents ofReccmpStatusReportonly to compute the project accuracy and project statistics. Unmatched entities are excluded from display and the serialized report files.When creating the
ReccmpStatusReport, skip any entities that match the "ignore these function names" and "ignore library functions" filters if either are enabled.Similarly, a
ReccmpStatusReportloaded from a file can also exclude entities by function name or theis_libraryflag. This is so you can diff against a report that includes more entities than you want and not see a lot of dropped functions.Store the
is_libraryflag for entities in the report. A future enhancement to the HTML report could show or hide these, similar to stubs.Store the
function_totalvalue in the report. A later update will display progress/accuracy calculations in the HTML report because we now have all the data.Drop the redundant
report_progress_statsfunction. We can get the number of implemented functions and the sum of the effective accuracy from the similarreport_function_accuracyfunction. We have stopped displaying "raw accuracy" (i.e. not rounding effective matches to 100%) but we still calculate it here.