Skip to content

Use report for progress calculation - #486

Open
disinvite wants to merge 8 commits into
isledecomp:masterfrom
disinvite:report-3
Open

Use report for progress calculation#486
disinvite wants to merge 8 commits into
isledecomp:masterfrom
disinvite:report-3

Conversation

@disinvite

@disinvite disinvite commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

This makes the following changes to ReccmpStatusReport and its child struct ReccmpComparedEntity:

  • The report created by reccmp-reccmp now contains both matched and unmatched entities. The reason is so we can use the contents of ReccmpStatusReport only to compute the project accuracy and project statistics. Unmatched entities are excluded from display and the serialized report files.

  • When creating the ReccmpStatusReport, skip any entities that match the "ignore these function names" and "ignore library functions" filters if either are enabled.

  • Similarly, a ReccmpStatusReport loaded from a file can also exclude entities by function name or the is_library flag. This is so you can diff against a report that includes more entities than you want and not see a lot of dropped functions.

  • Store the is_library flag for entities in the report. A future enhancement to the HTML report could show or hide these, similar to stubs.

  • Store the function_total value in the report. A later update will display progress/accuracy calculations in the HTML report because we now have all the data.

  • Drop the redundant report_progress_stats function. We can get the number of implemented functions and the sum of the effective accuracy from the similar report_function_accuracy function. We have stopped displaying "raw accuracy" (i.e. not rounding effective matches to 100%) but we still calculate it here.

Former changes that have been rebased out:

@disinvite

Copy link
Copy Markdown
Collaborator Author

After some thought, this is too big to comfortably review. Let's start with #493 then rebase this one.

@disinvite
disinvite marked this pull request as ready for review July 26, 2026 21:43
@disinvite
disinvite requested review from jonschz and madebr July 26, 2026 21:49
@disinvite

Copy link
Copy Markdown
Collaborator Author

The function total now embedded in the report should help finish up #450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant