Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/controller/evpn/fabric_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1008,12 +1008,11 @@ func (r *FabricReconciler) reconcileBGP(ctx context.Context, device *v1alpha1.De
bgp.Spec.AdminState = v1alpha1.AdminStateUp
bgp.Spec.ASNumber = fabric.Spec.Overlay.IBGP.ASNumber
bgp.Spec.RouterID = routerID
// "retain route-target all" is an eBGP-only construct; iBGP route
// reflectors reflect all EVPN routes regardless of imported RTs.
bgp.Spec.AddressFamilies = &v1alpha1.BGPAddressFamilies{
L2vpnEvpn: &v1alpha1.BGPL2vpnEvpn{
Enabled: true,
RouteTargetPolicy: &v1alpha1.BGPRouteTargetPolicy{
RetainAll: true,
},
},
}
return controllerutil.SetOwnerReference(fabric, bgp, r.Scheme)
Expand Down
5 changes: 2 additions & 3 deletions internal/controller/evpn/fabric_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,11 @@ var _ = Describe("Fabric Controller", func() {
g.Expect(lo0.Spec.IPv4).NotTo(BeNil())
g.Expect(bgp.Spec.RouterID).To(Equal(lo0.Spec.IPv4.Addresses[0].Addr().String()))

// L2VPN EVPN must be enabled with retainAll.
// iBGP fabric: retain route-target all is not configured.
g.Expect(bgp.Spec.AddressFamilies).NotTo(BeNil())
g.Expect(bgp.Spec.AddressFamilies.L2vpnEvpn).NotTo(BeNil())
g.Expect(bgp.Spec.AddressFamilies.L2vpnEvpn.Enabled).To(BeTrue())
g.Expect(bgp.Spec.AddressFamilies.L2vpnEvpn.RouteTargetPolicy).NotTo(BeNil())
g.Expect(bgp.Spec.AddressFamilies.L2vpnEvpn.RouteTargetPolicy.RetainAll).To(BeTrue())
g.Expect(bgp.Spec.AddressFamilies.L2vpnEvpn.RouteTargetPolicy).To(BeNil())

g.Expect(bgp.OwnerReferences).To(ContainElement(SatisfyAll(
HaveField("Kind", "Fabric"),
Expand Down
Loading