Repository navigation
Do not retain all route-targets in iBGP EVPN fabric - #707
Merged
Merged
Conversation
The Fabric controller set retain route-target all on every generated overlay BGP resource. That is an eBGP-only requirement: an iBGP route reflector reflects all EVPN routes to its clients regardless of locally imported route-targets, so retaining all RTs is unnecessary. Leave RouteTargetPolicy unset on the generated BGP resources. Signed-off-by: Sebastian Wagner <sebastian.wagner02@sap.com>
Merging this branch changes the coverage (3 decrease, 1 increase)
Coverage detailsCompared to commit d0c7aa9 (run #41619327985)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
felix-kaestner
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fabric controller set
retain route-target allon every generated overlayBGPresource. That is an eBGP-only requirement: an iBGP route reflector reflects all EVPN routes to its clients regardless of locally imported route-targets, so retaining all RTs is unnecessary.Per the Cisco Nexus 9000 NX-OS VXLAN BGP EVPN configuration guide,
retain route-target allappears only in the eBGP spine procedure ("Required for eBGP") and is absent from the iBGP spine procedure.Changes
reconcileBGPleavesRouteTargetPolicyunset on generated BGP resources