Skip to content

Do not retain all route-targets in iBGP EVPN fabric - #707

Merged
felix-kaestner merged 1 commit into
mainfrom
fabric-ibgp-disable-retain-rt-all
Nov 3, 2026
Merged

felix-kaestner merged 1 commit into
mainfrom
fabric-ibgp-disable-retain-rt-all

Conversation

@swagner-de

Copy link
Copy Markdown
Collaborator

The Fabric controller set retain route-target all on every generated overlay BGP resource. That is an eBGP-only requirement: an iBGP route reflector reflects all EVPN routes to its clients regardless of locally imported route-targets, so retaining all RTs is unnecessary.

Per the Cisco Nexus 9000 NX-OS VXLAN BGP EVPN configuration guide, retain route-target all appears only in the eBGP spine procedure ("Required for eBGP") and is absent from the iBGP spine procedure.

Changes

  • reconcileBGP leaves RouteTargetPolicy unset on generated BGP resources
  • Updated controller test assertions

The Fabric controller set retain route-target all on every generated
overlay BGP resource. That is an eBGP-only requirement: an iBGP route
reflector reflects all EVPN routes to its clients regardless of locally
imported route-targets, so retaining all RTs is unnecessary. Leave
RouteTargetPolicy unset on the generated BGP resources.

Signed-off-by: Sebastian Wagner <sebastian.wagner02@sap.com>
@github-actions github-actions Bot added the size/S label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (3 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 64.97% (-0.35%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 62.27% (+0.04%) 👍
github.com/ironcore-dev/network-operator/internal/controller/evpn 81.05% (-0.15%) 👎
github.com/ironcore-dev/network-operator/internal/controller/pool 72.57% (-0.42%) 👎
Coverage details

Compared to commit d0c7aa9 (run #41619327985)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/controller/evpn/fabric_controller.go 81.05% (-0.15%) 665 539 (-1) 126 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/ironcore-dev/network-operator/internal/controller/evpn/fabric_controller_test.go

@felix-kaestner
felix-kaestner merged commit 218d753 into main Nov 3, 2026
26 checks passed
@felix-kaestner
felix-kaestner deleted the fabric-ibgp-disable-retain-rt-all branch November 3, 2026 12:16
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Nov 9, 2026
@hardikdr hardikdr added this to Roadmap Nov 9, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations. size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants