Skip to content

fix: dropper AttributeError when redirect stub has no title #13188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TechGenius-Karan wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: dropper AttributeError when redirect stub has no title #13188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openlibrary/core/bookshelves.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ async def add_storage_items_for_redirects(cls, reading_log_keys, solr_docs: list
for key in missing_keys.copy():
if not work_to_edition_keys.get(key):
missing_keys.remove(key)
solr_docs.append(web.storage({"key": key}))
solr_docs.append(web.storage({"key": key, "title": ""}))

edition_keys_to_query = [work_to_edition_keys[key].split("/")[2] for key in missing_keys]
fq = f"edition_key:({' OR '.join(edition_keys_to_query)})"
Expand Down
2 changes: 1 addition & 1 deletion openlibrary/templates/my_books/dropper.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

$ data = { "work-key": work_key or "" }

$ title = work.title if work else (edition.get('title', '') if edition else '')
$ title = work.get('title', '') if work else (edition.get('title', '') if edition else '')
$ primary_action = render_template('my_books/primary_action', work_key, edition_key, (ctx.user and ctx.user.key), users_work_read_status, page_url, title)
$ dropdown_content = render_template('my_books/dropdown_content', user_lists, seed_key, work_key, edition_key, users_work_read_status, async_load=async_load)
$ dropper_label = _('More reading options for %(title)s', title=title) if title else _('More reading options')
Expand Down
Loading