fix: dropper AttributeError when redirect stub has no title#13188
Open
TechGenius-Karan wants to merge 1 commit into
Open
fix: dropper AttributeError when redirect stub has no title#13188TechGenius-Karan wants to merge 1 commit into
TechGenius-Karan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13169
fix
Technical
add_storage_items_for_redirectsinbookshelves.pyinserts a bareweb.storage({"key": key})stub for any reading log work that is missing from Solr and has no edition key. That stub then flows intodropper.htmlwhere line 29 doeswork.title— butweb.storage.__getattr__raisesAttributeErrorfor any missing key, producing the reported template error.Two-part fix:
bookshelves.py(line 282) — include"title": ""in the stub, consistent with howadd_storage_items_for_deletesalways includes a title in its stubs.dropper.html(line 29) — switch fromwork.titletowork.get('title', '')for defense in depth; this is already howeditionis handled on the same line.Testing
Reproduce: have a reading log entry whose work has been redirected to another OL key and was added without a specific edition. Open
/people/<username>/books/want-to-read.AttributeError: 'title'in template, falls back to default templateScreenshot
Backend-only fix, no UI change.
Stakeholders
@cdrini @mekarpeles