バトルの比較基準・勝敗反転を timedEffect の内容 compareBy/invertBattleWinner で書く - #120
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
旧 battleCompareByLevel/Cores/Cost・battleInvertBpWinner(6か所)を移して消す。挙動は変えない。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
REFACTOR_PLAN §2.2 の M8(期間つき継続効果)の続き。「このバトルの間、BPの代わりに Lv/コアの数/コストを比べる」「BPの高い方が破壊される」を
timedEffectの内容で書く。変わる挙動
battleCompareByLevelcompareBy { by: "level" }battleCompareByCorescompareBy { by: "cores" }battleCompareByCostcompareBy { by: "cost" }battleInvertBpWinnerinvertBattleWinnerbattle、置き場は今のstate.battle.compareBy*/invertBpWinnerのまま。バトル外は不発テスト
typecheck && validate:cards && validate:notes && validate:gaps && smoke:quiet && build:client全緑(smoke 12847件・❌0)未決・既知の制限