Repository navigation
fix/refactor: fix lookup logic and small refactor (remove redundant std::filesystem calls) - #16580
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vaxerski
reviewed
Oct 17, 2026
|
|
||
| bool NFsUtils::executableExistsInPath(const std::string& exe) { | ||
| if (!getenv("PATH")) | ||
| const char* const path = std::getenv("PATH"); |
Contributor
Author
|
I rethought this a bit and changed this: if (!fullPath.ends_with('/')) {
fullPath.push_back('/');
}
fullPath += exe;to: fullPath = dir;
fullPath /= exe;since std::filesystem::path can correctly handle extra '/' cppref |
vaxerski
approved these changes
Oct 19, 2026
hegjon
pushed a commit
to hegjon/hypoland
that referenced
this pull request
Oct 20, 2026
…filesystem calls) (hyprwm#16580) * fix lookup logic and small refactor (remove redundant std::filesystem calls) * replace CVarList with CVarList2 * fix if (cherry picked from commit 12f2425)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Before:
If file matches, but does not have std::filesystem::perms::others_exec the code returns false and stops lookup.
After:
Fixed, code continues search for exe file.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Did you use AI in any way shape or form in the making of this PR? If so, detail how you used it. (Undisclosed AI use is a violation of the AI Policy and is punishable)
No.
Is it ready for merging, or does it need work?
Ready for mergin.