Skip to content

fix: JsonTreeReader nextInt/nextLong silently truncates fractional numbers #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerryyy985 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: JsonTreeReader nextInt/nextLong silently truncates fractional numbers #3094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gson/src/main/java/com/google/gson/internal/bind/JsonTreeReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,10 @@ public long nextLong() throws IOException {
long result;
try {
result = primitive.getAsLong();
if (token == JsonToken.NUMBER && result != primitive.getAsDouble()) {
// Mirror JsonReader: reject numbers that cannot be exactly represented as a long
throw new NumberFormatException("Expected a long but was " + primitive.getAsString());

@Marcono1234 Marcono1234 Aug 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably have to move this out of the try-catch(NumberFormatException), otherwise this exception is redundantly wrapped.

(same for nextInt below as well)

}
} catch (NumberFormatException e) {
throw numberFormatException("Expected a long but was " + primitive.getAsString(), e);
}
Expand All @@ -298,6 +302,10 @@ public int nextInt() throws IOException {
int result;
try {
result = primitive.getAsInt();
if (token == JsonToken.NUMBER && result != primitive.getAsDouble()) {
// Mirror JsonReader: reject numbers that cannot be exactly represented as an int
throw new NumberFormatException("Expected an int but was " + primitive.getAsString());
}
} catch (NumberFormatException e) {
throw numberFormatException("Expected an int but was " + primitive.getAsString(), e);
}
Expand Down