fix: JsonTreeReader nextInt/nextLong silently truncates fractional numbers - #3094
Open
Jerryyy985 wants to merge 1 commit into
Open
fix: JsonTreeReader nextInt/nextLong silently truncates fractional numbers#3094Jerryyy985 wants to merge 1 commit into
Jerryyy985 wants to merge 1 commit into
Conversation
…mbers JsonTreeReader.nextInt/nextLong call Number.intValue()/longValue() directly, which silently truncates fractional values (42.123 -> 42), while the streaming JsonReader throws NumberFormatException for the same input. Fix: mirror JsonReader's precision check — reject NUMBER tokens whose double value is not exactly representable as the requested integer type. Fixes google#2817
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Marcono1234
reviewed
Aug 16, 2026
| result = primitive.getAsLong(); | ||
| if (token == JsonToken.NUMBER && result != primitive.getAsDouble()) { | ||
| // Mirror JsonReader: reject numbers that cannot be exactly represented as a long | ||
| throw new NumberFormatException("Expected a long but was " + primitive.getAsString()); |
Contributor
There was a problem hiding this comment.
Probably have to move this out of the try-catch(NumberFormatException), otherwise this exception is redundantly wrapped.
(same for nextInt below as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonTreeReader.nextInt()/nextLong()callNumber.intValue()/longValue()directly, which silently truncates fractional values (42.123→42), while the streamingJsonReaderthrowsNumberFormatExceptionfor the same input. Behavior between the two readers is inconsistent.Fix
Mirror
JsonReader's precision check: for NUMBER tokens, reject values whose double representation is not exactly equal to the requested integer type (result != getAsDouble()guard, same asJsonReader.nextInt/long).Verified against a 12-case boundary matrix (fractional / integral / overflow / NaN / BigInteger / BigDecimal paths) — TreeReader now matches JsonReader behavior with no regressions on valid inputs.
Fixes #2817