Fix spring-damper damping regime scaling - #3522
Open
Vedangalle wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3521.
Problem
mju_springDamperpreviously comparedKv^2 - 4*Kpdirectly with the fixed absolute valuemjMINVAL. A consistent time rescaling multiplies the discriminant by the square of the time-scale factor, so this comparison could change the selected damping regime even though the physical trajectory was unchanged.For one equivalent overdamped pair, the unscaled call returned
0.7946142382307649, while the time-scaled call returned0.0404276819945128. Both should return0.7946142382307650.The updated tolerance is relative to
max(Kv^2, 4*abs(Kp)). It therefore scales with the discriminant and retains the near-critical branch without changing the public API.Validation
engine_util_misc_testbinary: 66/66 passed.1e-2through1e-12; maximum absolute difference was5.33e-15.Local environment: macOS, AppleClang 21, CMake 4.4.2, Release build with
MUJOCO_HARDEN=ON.