Convert Newton angular attributes to MuJoCo units - #3518
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Convert Newton angular attributes to MuJoCo units#3518sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the two angular-unit conversion defects reported in #3472 for the Newton USD schema read path.
Newton authors
newton:dampingfor angular degrees as effort-seconds per degree, while MuJoCo stores angular joint damping per radian. Newton also authorsnewton:mimicCoef0in degrees for revolute joints, while MuJoCo'smjEQ_JOINTconstant is in radians.This change:
180/pifor angular MuJoCo jointsnewton:mimicCoef0from degrees to radians for USD revolute jointsmjc:paths unchangedAddresses parts 1 and 2 of #3472. The separate
newton:mimicEnableddefect is already being handled by #3477.Validation
main(80d1b0d81148e4f85b0260bc0d5f0ca92ca52113).99b71edb13b25905aa5938dfe6774b31147e35fb) and changes onlyplugin/usd_decoder/usd_decoder.cc.git diff --checkpasses.