Fix size_t atomic add on 32-bit MSVC - #3512
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the width-appropriate MSVC interlocked intrinsic for
size_t.engine_crossplatform.hcurrently mapsmj_atomic_add_size_tto_InterlockedExchangeAdd64for every non-Clang MSVC build. That is correct on 64-bit Windows, but 32-bit Windows uses a 32-bitsize_tand the x86 build can fail to link with an unresolved__InterlockedExchangeAdd64.This keeps
_InterlockedExchangeAdd64on_WIN64and uses_InterlockedExchangeAddon 32-bit MSVC.This revives the still-relevant fix from closed, unmerged PR #3358 by @BillyONeal, rebased onto current
main.Validation
Final diff is one file and one commit. The 64-bit branch is unchanged; the new branch is selected only for 32-bit MSVC.
An x86 MSVC toolchain is not available in this environment, so the Windows build was not run locally.