Accept NumPy integers for rollout sizing - #3511
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
rolloutto accept NumPy integer scalar values fornstepandchunk_size.These values commonly come from NumPy computations.
np.int64(3)is a valid integral value but is not an instance of Python's built-inint, so current validation rejects it before the rollout reaches the native implementation.This change:
np.integeralongside Pythonintfornstepnp.integeralongside Pythonintforchunk_sizeThis revives the still-relevant fix from closed, unmerged PR #3300 against current
main.Validation
The final branch is based directly on current
mainand contains one focused commit changing onlypython/mujoco/rollout.pyplus a regression test.The MuJoCo Python extension was not built in this execution environment, so the new runtime regression test was not executed locally and no local test pass is claimed.