Fix msh2obj texcoord error formatting - #3510
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Collaborator
|
If you continue to spam the repo, you will be blocked @sylvesterkaczmarek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the malformed texcoord-count diagnostic in
mujoco.msh2obj.The validation currently splits the message across two literals but only the first is an f-string. As a result, malformed legacy MSH files report the literal text
2*{ntexcoord}instead of the expected count.This change adds the missing f-string prefix and regression coverage that declares five texcoords while serializing only one, verifying the error reports
2 != 2*5.This revives the still-relevant fix from closed, unmerged PR #3302 against current
main.Validation
The final branch is based directly on current
mainand contains one focused commit changing onlypython/mujoco/msh2obj.pyplus a regression test.The MuJoCo Python test environment was not built here, so no local test execution is claimed.