Fix swapped MJX ray empty-return types - #3506
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
btaba
approved these changes
Aug 24, 2026
Author
|
@btaba thanks for taking the time to review and approve this. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the ray filter excludes every geom,
mjx.rayreturns an integer in the distance slot and a float in the geom-id slot, contrary to its documented(distance, geom id)contract and its normal return path.This change fixes the sentinel order, aligns the docstring, and adds a regression test asserting that the early-return dtypes match the normal path.
Context
Closed, unmerged PR #3326 identified the same bug. Current
mainstill contains it and no active replacement was found.Validation
mainray.pyandray_test.py