Avoid unsupported GLFW window position queries on Wayland - #3505
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Avoid unsupported GLFW window position queries on Wayland#3505sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid calling
glfwGetWindowPoswhen Simulate is running on Wayland.GLFW documents that Wayland clients do not know their global window position, and the current calls generate
GLFW_FEATURE_UNAVAILABLEwarnings. In the Python passive viewer this surfaces as the warning reported in #2393 and can interfere with viewer interaction depending on the GLFW Python error callback.This change:
glfwGetPlatformto Simulate's dynamic GLFW dispatch table when building against GLFW 3.4+glfwGetPlatformis unavailableFixes #2393.
Validation
The final branch is based directly on current
mainand contains one focused commit (12a2c02379807151047c4fd918153450f9098ce6).Final diff:
simulate/glfw_adapter.cc: 14 additions, 2 deletionssimulate/glfw_dispatch.cc: 3 additionssimulate/glfw_dispatch.h: 3 additionsI could not run the Wayland GUI regression locally in this execution environment, so no local runtime test pass is claimed. The change follows the root cause identified in the issue discussion and preserves non-Wayland behaviour.