Normalize Unity heightfield data before writing to MuJoCo - #3500
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Normalize Unity heightfield data before writing to MuJoCo#3500sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1930.
Summary
Unity heightfields with a maximum sample below 1 are currently scaled twice: the generated MuJoCo
hfieldsize already uses the observed physical height range, whileUpdateHeightFieldData()writes the original unnormalized samples intohfield_data.This change:
MinimumHeightas well asMaximumHeight;hfield_datasamples to[0, 1]using that source range;This keeps the MuJoCo heightfield data consistent with the physical range encoded in the generated
hfieldsize.Validation
mainatf7da3d295b828478e0171967a7fa3fe6bb2ec922.