Skip to content

fix(replays): Fix web vital tooltip rendering in the replay timeline #119070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DominikB2014 merged 1 commit into from
Jul 7, 2026
+13 −5
Merged

fix(replays): Fix web vital tooltip rendering in the replay timeline #119070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/components/replays/breadcrumbs/breadcrumbWebVital.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ export function BreadcrumbWebVital({
}

return (
<Flex gap="lg" justify="between" align="start">
<NoMarginWrapper flex="1">
<Flex direction="column" gap="sm" align="start">
<NoMarginWrapper>
<StructuredEventData
initialExpandedPaths={expandPaths ?? []}
onToggleExpand={(expandedPaths, path) => {
Expand Down Expand Up @@ -156,6 +156,7 @@ const SelectorButton = styled(Button)`
`;

const NoMarginWrapper = styled(Flex)`
width: 100%;
pre {
margin: 0;
flex: 1;
Expand Down
13 changes: 10 additions & 3 deletions static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {getFrameDetails} from 'sentry/utils/replays/getFrameDetails';
import {useActiveReplayTab} from 'sentry/utils/replays/hooks/useActiveReplayTab';
import {useCrumbHandlers} from 'sentry/utils/replays/hooks/useCrumbHandlers';
import type {ReplayFrame} from 'sentry/utils/replays/types';
import {isWebVitalFrame} from 'sentry/utils/replays/types';
import type {GraphicsVariant} from 'sentry/utils/theme';

const NODE_SIZES = [8, 12, 16];
Expand Down Expand Up @@ -106,14 +107,20 @@ function Event({
</Container>
);

// Web vital frames render an expandable JSON block that needs more room than
// the default tooltip width, otherwise its content wraps to a very tall sliver.
const hasWebVitalFrame = frames.some(isWebVitalFrame);
const tooltipWidth = hasWebVitalFrame ? 400 : 291;
const mobileMaxWidth = hasWebVitalFrame ? 300 : 220;

const overlayStyle = css`
/* We make sure to override existing styles */
padding: ${theme.space.xs} !important;
max-width: 291px !important;
width: 291px;
max-width: ${tooltipWidth}px !important;
width: ${tooltipWidth}px;

@media screen and (max-width: ${theme.breakpoints.sm}) {
max-width: 220px !important;
max-width: ${mobileMaxWidth}px !important;
}
`;

Expand Down
Loading