fix(replays): Fix web vital tooltip rendering in the replay timeline#119070
Open
DominikB2014 wants to merge 1 commit into
Open
fix(replays): Fix web vital tooltip rendering in the replay timeline#119070DominikB2014 wants to merge 1 commit into
DominikB2014 wants to merge 1 commit into
Conversation
Web vital markers in the replay timeline render an expandable JSON block plus an "All Web Vitals" link. In the default 291px tooltip the JSON column was squeezed so narrow that even a short key like "value" wrapped to two characters per line, and the nowrap link could overflow the tooltip. Widen the tooltip to 400px only for web vital frames (other breadcrumb tooltips keep their width), and stack the link below the full-width JSON block so it can never be pushed outside the tooltip.
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes overflow on replays tooltip
Before
(notice
all web vitalsis cut off when json collapsed, and json looks really narrow when expanded)After
Ai Summary
Fixes REPLAY-862 — the tooltip for web vital markers on the replay timeline rendered "weird".
Web vital markers show an expandable
StructuredEventDataJSON block alongside an "All Web Vitals" link. In the default 291px tooltip the JSON column was squeezed so narrow that even a short key likevaluewrapped to two characters per line (making the tooltip very tall), and thenowraplink could overflow the tooltip edge.frames.some(isWebVitalFrame)); all other breadcrumb tooltips keep their existing 291px width.Test plan
valueon one line) and the "All Web Vitals" link sits inside the tooltip, below the JSON.