Skip to content

refactor: Simplify border point implementation - #1248

Open
MoritzWeber0 wants to merge 16 commits into
feat/render-borderpoints-dynamicallyfrom
review/dynamic-borderpoints
Open

MoritzWeber0 wants to merge 16 commits into
feat/render-borderpoints-dynamicallyfrom
review/dynamic-borderpoints

Conversation

@MoritzWeber0

@MoritzWeber0 MoritzWeber0 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member
  • Border points are expected to be between exactly two countries. There was just one case where more than two countries were used: Eurostar on the UK page. Since Eurostar didn't show the list of countries on the Germany page either, I removed the option to include multiple countries. Replaced with country France, all Eurostar services from UK pass France anyway.
  • Add a new shortName to operators and use it as label for border points. For consistency, I changed LTG-Link to LTG, Hellenic Train to HT and ZSSK / ZSR to ZSSK as short names.
  • Render HTML directly instead of Markdown, move implementation to own folder. More fail-safe than the generation of markdown tables.
  • Move the border points selection via IDs to the corresponding countries front matter files. Only the border point definitions stay in the border points file.
  • Properly register the border points file as singleton in the CMS. Add relations from the border points definition on the country pages to the values of the singelton, include a link where to edit it. Add a border points editor component.
  • Removed the sort attribute since we have full-control over the sorting in the border points file. Performed a one-time sorting on the element where sort: true was set.
  • Since the variant attribute of the expander shortcode is no longer needed (faq and border points have their own handling), I replaced variant with icon to allow more flexibility.

@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit fc1e929
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6ac8045db548aa0008bff1fd
😎 Deploy Preview https://deploy-preview-1248--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0
MoritzWeber0 marked this pull request as ready for review October 8, 2026 21:00
@MoritzWeber0
MoritzWeber0 requested a review from lenderom October 8, 2026 21:00
@MoritzWeber0 MoritzWeber0 changed the title refactor: Simplify border point logic refactor: Simplify border point implementation Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant