Repository navigation
Conversation
lenderom
added
the
technical
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
While looking at the border points, I came up with some questions regarding the handling of some special cases, for example the global fare operators. I added an issue for it. It probably needs a bit of discussion: #1245 |
There was a problem hiding this comment.
Cool, thanks for the implementation! It's a good foundation for future features like the border point map. I have a few improvement ideas (because of the amount, I split it into another PR). If you are fine with the changes, you can just merge #1248 into this PR. Otherwise, feel free to open conversations in the other PR. It also includes a bug fix for the CMS which doesn't seem to work in this branch. The PR description explains the changes.
There was a problem hiding this comment.
For some operators, the list gets really long (for example DB). I'm not sure if there is much value in such a list, even if the calculation makes more sense now.
There was a problem hiding this comment.
We really need to check here if this is even right. I think some Operators doesn't have any borderpoints to DB (like SP oder BLS)
There was a problem hiding this comment.
We have to apply the change to the new north macedonia page as well.
- Border points are expected to be between exactly two countries. There was just one case where more than two countries were used: Eurostar on the UK page. Since Eurostar didn't show the list of countries on the Germany page either, I removed the option to include multiple countries. Replaced with country France, all Eurostar services from UK pass France anyway. - Add a new shortName to operators and use it as label for border points. For consistency, I changed LTG-Link to LTG, Hellenic Train to HT and ZSSK / ZSR to ZSSK as short names. - Render HTML directly instead of Markdown, move implementation to own folder. More fail-safe than the generation of markdown tables. - Move the border points selection via IDs to the corresponding countries front matter files. Only the border point definitions stay in the border points file. - Properly register the border points file as singleton in the CMS. Add relations from the border points definition on the country pages to the values of the singelton, include a link where to edit it. Add a border points editor component. - Removed the sort attribute since we have full-control over the sorting in the border points file. Performed a one-time sorting on the element where `sort: true` was set. - Since the variant attribute of the expander shortcode is no longer needed (faq and border points have their own handling), I replaced variant with icon to allow more flexibility.
This branch has not been deployed
2 participants
Generate the borderpoints dynamically and also update the neighbouring operators.
There are some missing borderpoints like for Eurostar. We can add them in a different PR, for the moment I would like to migrate the current content state. However on some borderpoints they were not consistently named. So I decided by myself to the best of my knowledge and belief for each borderpoint where this was the case.