-
Notifications
You must be signed in to change notification settings - Fork 168
ci: refactor workflows for release branching #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jescalada
wants to merge
11
commits into
finos:main
Choose a base branch
from
jescalada:1517-refactor-workflows-for-release-branching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a1c1ef9
ci: update npm.yml to work with multiple release branches
jescalada 559e854
ci: rename release-drafter.yml to release-drafter-config.yml
jescalada 0d17e1e
ci: fix release-drafter-config.yml bug, formatting issues
jescalada c14db3d
ci: add release-drafter as separate workflow
jescalada 18a10be
ci: add PR auto-labeler workflow
jescalada aa6db4f
Merge branch 'main' into 1517-refactor-workflows-for-release-branching
jescalada 7b584d0
Merge branch 'main' into 1517-refactor-workflows-for-release-branching
jescalada d627e9c
fix: remove release drafter from pr-lint.yml workflow
jescalada 1f9e06c
ci: add "edited" trigger to auto-label.yml
jescalada 57285e0
Merge branch 'main' into 1517-refactor-workflows-for-release-branching
jescalada 3ebdb71
Merge branch 'main' into 1517-refactor-workflows-for-release-branching
jescalada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| name: Add PR Labels | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, reopened, synchronize, edited] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| auto_label: | ||
| permissions: | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: release-drafter/release-drafter/autolabeler@563bf132657a13ded0b01fcb723c5a58cdd824e2 | ||
| with: | ||
| config-name: release-drafter-config.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Release Drafter | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - 'release/**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| update_release_draft: | ||
| permissions: | ||
| # Required to create/update the draft release | ||
| # Autolabeling runs in a separate workflow so this job only | ||
| # needs to read merged PRs | ||
| contents: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 # v2.16.0 | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - uses: release-drafter/release-drafter@563bf132657a13ded0b01fcb723c5a58cdd824e2 | ||
| with: | ||
| # Target the branch that triggered this run | ||
| # Ex: "release/2.1" becomes the commitish for the draft | ||
| commitish: ${{ github.ref_name }} | ||
| repository: ${{ github.repository }} | ||
| config-name: release-drafter-config.yml | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commitishcontrols the target branch of the generated release, but it does not by itself isolate drafts belonging to concurrent release branchesIt's probably worth adding a
filter-by-commitish: true. When set to true, it restricts the included commits to those that are descendants of the previous release's target_commitish (the commit or branch associated with the last release), rather than including all commits since the beginning of the repository or a fixed date.