ci: refactor workflows for release branching#1520
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
==========================================
+ Coverage 85.75% 85.98% +0.22%
==========================================
Files 85 85
Lines 8448 8448
Branches 1457 1457
==========================================
+ Hits 7245 7264 +19
+ Misses 1172 1154 -18
+ Partials 31 30 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@kriswest Would be great to merge this in as we prepare for the 2.1 release! I've already made the |
|
@re-vlad could you look at this one |
There was a problem hiding this comment.
Renaming .github/release-drafter.yml to .github/release-drafter-config.yml breaks the release-drafter job in pr-lint.yml: the with: block (lines 58–59) does not set config-name, so the action still looks for the default .github/release-drafter.yml and will likely fail at runtime (with message: "config file not found").
There was a problem hiding this comment.
The job also keeps updating a draft release on main (commitish: main), which conflicts with the GitLabFlow model where drafts are created per release/* branch by the new .github/workflows/release-drafter.yml workflow. Autolabeling is now handled by auto-label.yml (.github/workflows/auto-label.yml), so this job looks redundant.
Suggested fix: remove the release-drafter job from pr-lint.yml and add edited to auto-label.yml pull_request_target.types
Now located at .github/workflows/release-drafter.yml
|
@re-vlad Thanks for the review! I forgot to remove the old release-drafter step from The point of I think both of your comments stem from that oversight of mine. Note that in my release tests, the updated file is being used, that's why I didn't see any related failures when making PRs or releases. |
|
@kriswest Ready for a final check! |
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
@finos/git-proxy-maintainers Just need this merged to kick off the 2.1 release 🙂 |
andypols
left a comment
There was a problem hiding this comment.
LGTM - but think it's a good idea to add the filter-by-commitish setting.
| # Ex: "release/2.1" becomes the commitish for the draft | ||
| commitish: ${{ github.ref_name }} | ||
| repository: ${{ github.repository }} | ||
| config-name: release-drafter-config.yml |
There was a problem hiding this comment.
commitish controls the target branch of the generated release, but it does not by itself isolate drafts belonging to concurrent release branches
It's probably worth adding a filter-by-commitish: true. When set to true, it restricts the included commits to those that are descendants of the previous release's target_commitish (the commit or branch associated with the last release), rather than including all commits since the beginning of the repository or a fixed date.
Closes #1517.
This refactors the release drafting and NPM publisher automation to work with release branches, as described in #1516. I've already updated #1516 with a step-by-step guide and a troubleshooting section based on my own testing.
Although it's a bit of a mess, I've replicated the release process in my git-proxy fork: