Skip to content

make account type searchable#289

Open
hackmod wants to merge 3 commits into
ethereumclassic:devfrom
EthersocialNetwork:search-account-type
Open

make account type searchable#289
hackmod wants to merge 3 commits into
ethereumclassic:devfrom
EthersocialNetwork:search-account-type

Conversation

@hackmod

@hackmod hackmod commented Mar 16, 2019

Copy link
Copy Markdown
Contributor
  • fixed tools/richlist.js bug with a geth/parity style genesis.json
  • support partial accounts update with a given json file. (e.g) $ node tools/richlist.js myaccounts.json

support searchable account like as Account or Contract
image

or we can use user-defined account type like as follow.

        "genesisAddress": "predefined-addr.json",
        "accountTypes": {
            "1": "Exchanges", // saved as  (1<<3) | 0x4 (user-defined bit)
            "2": "Genesis Alloc" // saved as (2<<3) | 0x4
        },

user defined accounts could be inserted like as follow.

// predefined-addr.json
//...
  "0xfb8b7efb0xxxxxxxxxxxc0f0abc8c555684653587": {
    "type": 20 // 20 == (2 << 3) | 0x4
  },
  "0xfdbdaecxxxxxxxxxxxxxx18d94e0b8533f2801818": {
    "type": 20
  },
//...

@hackmod
hackmod force-pushed the search-account-type branch from 156112d to aa68e32 Compare March 16, 2019 19:08
@kimisan

kimisan commented Mar 16, 2019

Copy link
Copy Markdown
Member

wow, interesting.

@ghost

ghost commented Mar 17, 2019

Copy link
Copy Markdown

Conflicts with #288 @hackmod

@realcodywburns realcodywburns mentioned this pull request Mar 19, 2019
1 task
@ghost

ghost commented Mar 22, 2019

Copy link
Copy Markdown

I don't think it is a good idea to define accounts and tokens on json, you should rather

  1. implement them directly on db
  2. force users to customize their accounts

@ghost

ghost commented Mar 25, 2019

Copy link
Copy Markdown

Rebase your PR!

@hackmod
hackmod force-pushed the search-account-type branch from b4689d1 to 9394382 Compare January 14, 2020 11:57
@hackmod

hackmod commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants