Conversation
Backport: Dev into Master
* improve documentation * update solc and mongoose version * update db.js * drop tools/price.js from docker-compose.yml
Update mongoose version
* author tag no longer required by search engine * fix footer.html * minify css * renamed custom.css to etc-explorer.css * update footer.html hyperlinks to open on new tab
Remove author from html tags
* gulpified plugins * gulpified fonts * gulpified eslint * cleanup fonts & plugins * based on @hackmod's edit
Gulpified plugins
cleanup: remove unnecessary files
phyro
reviewed
Apr 2, 2019
phyro
left a comment
phyro
left a comment
Member
There was a problem hiding this comment.
Apart from the comments this seems fine but I'm not familiar with gulpify. Someone else with the understanding of it should take a look
mikeyb
approved these changes
Apr 9, 2019
mikeyb
left a comment
mikeyb
left a comment
Member
There was a problem hiding this comment.
+1 looks good to me. as discussed will be nice to get the jquery/datatables packages updated soon
* update mongoose package version * update web3-explorer package version * update mocha package version
phyro
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.