-
Notifications
You must be signed in to change notification settings - Fork 22
Add report issue button in app info, and add option for apps to require minimum firmware version #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add report issue button in app info, and add option for apps to require minimum firmware version #92
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7ec039d
if app has requireFw, only upload if fw is greater than it
RKBoss6 f1a211f
Add report issue button for each app in app info
RKBoss6 684c8c0
Add button to handle reporting issue in showPrompt
RKBoss6 084dc92
Use versionLess, and resolve url for issue in index.js
RKBoss6 f7458cb
remove url logic from ui.js
RKBoss6 1399c87
fix conditional error
RKBoss6 f7c9701
resolve githubIssue so index.js can handle it
RKBoss6 5d548e7
Fix syntax error in promise resolution
RKBoss6 5bc2582
Fix firmware version comparison logic
RKBoss6 9e50051
Just pass in `true`, not the app
gfwilliams 71bd24e
Update GitHub issue report URL to include author
RKBoss6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.