Skip to content

Add report issue button in app info, and add option for apps to require minimum firmware version #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfwilliams merged 11 commits into from
Jul 3, 2026
Merged

Add report issue button in app info, and add option for apps to require minimum firmware version #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7ec039d
if app has requireFw, only upload if fw is greater than it
RKBoss6 Jun 28, 2026
f1a211f
Add report issue button for each app in app info
RKBoss6 Jun 29, 2026
684c8c0
Add button to handle reporting issue in showPrompt
RKBoss6 Jun 29, 2026
084dc92
Use versionLess, and resolve url for issue in index.js
RKBoss6 Jun 30, 2026
f7458cb
remove url logic from ui.js
RKBoss6 Jun 30, 2026
1399c87
fix conditional error
RKBoss6 Jun 30, 2026
f7c9701
resolve githubIssue so index.js can handle it
RKBoss6 Jun 30, 2026
5d548e7
Fix syntax error in promise resolution
RKBoss6 Jun 30, 2026
5bc2582
Fix firmware version comparison logic
RKBoss6 Jun 30, 2026
9e50051
Just pass in `true`, not the app
gfwilliams Jun 30, 2026
71bd24e
Update GitHub issue report URL to include author
RKBoss6 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,15 @@ function showAppInfo(appid, installedVersion) {
const infoPart = infoTxt.length>0 ? marked(infoTxt.join("<br>")) : "";
const changelogPart = changelogText ? changelogText.replace(/\n/g, "<br/>") : "";
const changeLogHeading = changelogPart ? "<hr><strong>ChangeLog:</strong><br>" : "";
showPrompt(app.name + " App Information", infoPart + changeLogHeading + changelogPart, {ok: true,}, false).catch(() => {});
showPrompt(app.name + " App Information", infoPart + changeLogHeading + changelogPart, {ok: true, githubIssue: true}, false).catch(() => {}).then((c)=>{
if(c=="githubIssue"){
const encodedTitle = encodeURIComponent(`[${app.name}] Describe the issue...`);
const authorText = app.author ? encodeURIComponent(`@${app.author}`):"";
window.open(`https://github.com/espruino/BangleApps/issues/new?template=bangle-bug-report-custom-form.yaml&title=${encodedTitle}&fwversion=${device.version?device.version:""}&author=${authorText}`,'_blank');
}
}

);
});
}
function getAppDescription(app) {
Expand Down Expand Up @@ -1045,6 +1053,12 @@ function uploadApp(app, options) {
}

return startOperation({name:"App Upload"}, () => getInstalledApps().then(()=>{
if (app.requiredFw!==undefined){
if(Utils.versionLess(device.version,app.requiredFw)) {
showToast(`App "${app.name}" requires firmware version ${app.requiredFw} or higher. You have version ${device.version}. To install this app, please update your firmware.`,"warning");
return;
}
}
if (device.appsInstalled.some(i => i.id === app.id)) {
return updateApp(app, {noNewOperation:true /*in 'App Upload'*/});
}
Expand Down
2 changes: 2 additions & 0 deletions js/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ function showPrompt(title, text, buttons, shouldEscapeHtml) {
${buttons.yes?'<button class="btn btn-primary" isyes="1">Yes</button>':''}
${buttons.no?'<button class="btn" isyes="0">No</button>':''}
${buttons.ok?'<button class="btn" isyes="1">Ok</button>':''}
${buttons.githubIssue?`<button class="btn" id="githubIssue">Report Issue</button>`:''}
${buttons.footer?`<span style="float:left">${buttons.footer}<span>`:""}
</div>
`:``}
Expand All @@ -131,6 +132,7 @@ function showPrompt(title, text, buttons, shouldEscapeHtml) {
event.preventDefault();
let isYes = event.target.getAttribute("isyes")=="1";
if (isYes) resolve();
else if (event.target.id=="githubIssue") resolve("githubIssue");
else reject("User cancelled");
modal.remove();
});
Expand Down
Loading