Skip to content

Write dialogue for Template Elder #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edwardvilcamonje-max wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −19
Open

Write dialogue for Template Elder #2817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3919a85
dialogue for Template Elder
edwardvilcamonje-max Sep 1, 2026
03d1f45
fix: update template quest starter dialogue and scene configuration
edwardvilcamonje-max Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions scenes/game_elements/characters/npcs/elder/components/template_quest_starter.dialogue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,16 @@
# SPDX-FileCopyrightText: The Threadbare Authors
# SPDX-License-Identifier: MPL-2.0
~ start
Template Elder: [[Hi|Hello|Greetings]], StoryWeaver. We've been waiting for you. Our world is unraveling!
Template Elder: We need you to recover the Sacred Elements: the threads of Memory, Imagination, and Spirit! Will you help us?
do balloon.hide()
TemplateQuest Elder: [[Hi|Hello|Greetings]]! We've been waiting for you. Our world is full of stories!
TemplateQuest Elder: We have a StoryQuest template for you to explore. This story is yours to adapt and make your own!
do show_storybook()
if chosen_quest == null:
% Template Elder: Please stay. Our world will perish without your help!
% Template Elder: I hope to see you again. We really need you!
% Template Elder: The people of Threadbare are counting on you. I hope you change your mind!
else:
Template Elder: We believe in you, StoryWeaver. Become the hero, and see where the path leads.
% TemplateQuest Elder: Take a look at this template. Perhaps it will inspire a story of your own!
% TemplateQuest Elder: This story is waiting to be explored, adapted, and brought to life!
% TemplateQuest Elder: We hope it sparks your imagination!
Comment on lines +8 to +10

@wjt wjt Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the tone of these is quite right because in this path the player has chosen not to play the template. These should be encouraging the player to come back later and take a look.

else:s

@manuq manuq Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it's interesting that the Dialogue Manager doesn't complain about this extra "s", not in syntax check or at runtime. But is not needed.

Suggested change
else:s
else:

TemplateQuest Elder: Explore the template, adapt the story, and see where the path leads.

@wjt wjt Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coding style checker is going to complain about the use of spaces rather than tabs here.

=> END
~ go_to_loom
Template Elder: Go on, StoryWeaver: take the threads to the Eternal Loom.
=> END
~ threads_incorporated
Template Elder: Thank you, StoryWeaver! The fabric of the world slowly heals!
Template Elder: Go forth: our world still needs your help.
=> END
~ no_quests

@wjt wjt Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elder.gd code assumes that the no_quests title exists:

threadbare/scenes/game_elements/characters/npcs/elder/components/elder.gd

Lines 111 to 112 in 4cd38e1

elif not _quests:
talk_behavior.title = "no_quests"

so please keep that one. (In practice it will never be reached, so I suggest keeping the existing line of dialogue.)

@wjt wjt Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any change here. I think this must be in a copy of the file you have made locally but not committed.

Template Elder: I don't have any quests for you. Talk to my fellow Elders.
=> END
TemplateQuest Elder: Go on: take your story to the Eternal Loom.
=> END
2 changes: 1 addition & 1 deletion scenes/game_elements/characters/npcs/elder/components/template_quest_starter.dialogue.import
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
importer="dialogue_manager"
importer_version=15
type="Resource"
uid="uid://dg0fe4uwdjlbd"
uid="uid://caovnmf5h7ro7"
path="res://.godot/imported/template_quest_starter.dialogue-7a4ffa3d0dcf216ce61756a0de5e4ce2.tres"

[deps]
Expand Down
2 changes: 1 addition & 1 deletion scenes/game_elements/characters/npcs/elder/template_elder.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[ext_resource type="Script" uid="uid://cms2wqtbxjl1h" path="res://scenes/game_logic/sprite_behaviors/random_frame_sprite_behavior.gd" id="3_ewone"]
[ext_resource type="Script" uid="uid://du8wfijr35r35" path="res://scenes/game_elements/props/interact_area/interact_area.gd" id="3_ftke6"]
[ext_resource type="Script" uid="uid://edcifob4jc4s" path="res://scenes/game_logic/talk_behavior.gd" id="4_m4ftv"]
[ext_resource type="Resource" uid="uid://dg0fe4uwdjlbd" path="res://scenes/game_elements/characters/npcs/elder/components/template_quest_starter.dialogue" id="5_l4hfl"]
[ext_resource type="Resource" uid="uid://dg0fe4uwdjlbd" path="res://scenes/game_elements/characters/npcs/elder/components/template_quest_starter1.dialogue" id="5_l4hfl"]

@wjt wjt Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've copied the file, edited the copy, but then not committed the copy.

You should edit the original file, and restore this.

[ext_resource type="AudioStream" uid="uid://dxbxx6x5h7d8p" path="res://assets/third_party/sounds/characters/npcs/elder/BookPage.ogg" id="6_wjjqs"]

[sub_resource type="CapsuleShape2D" id="CapsuleShape2D_3vyb7"]
Expand Down
Loading