Write dialogue for Template Elder - #2817
Conversation
edwardvilcamonje-max
changed the title
edwardvilcamonje-max
changed the title
| run/main_scene="uid://huuo8mnwsphv" | ||
| config/project_settings_override="user://custom_overrides.cfg" | ||
| config/features=PackedStringArray("4.7", "GL Compatibility") | ||
| config/features=PackedStringArray("4.6", "GL Compatibility") |
There was a problem hiding this comment.
| config/features=PackedStringArray("4.6", "GL Compatibility") | |
| config/features=PackedStringArray("4.7", "GL Compatibility") |
|
Play this branch at https://play.threadbare.game/branches/edwardvilcamonje-max/main/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
left a comment
wjt
left a comment
There was a problem hiding this comment.
Please see https://github.com/endlessm/threadbare/wiki/Contributing#pull-request-descriptions and tweak the title & description:
- Remove the issue number from the PR title
- No need to add "Description:"
- "The new dialogue was added in the same directory and format as the existing Elder dialogue files." - this isn't quite right, you've edited an existing file rather than adding a new one.
- "resolve:#1102" is not the correct syntax. https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword documents the syntax here.
| % TemplateQuest Elder: Take a look at this template. Perhaps it will inspire a story of your own! | ||
| % TemplateQuest Elder: This story is waiting to be explored, adapted, and brought to life! | ||
| % TemplateQuest Elder: We hope it sparks your imagination! |
There was a problem hiding this comment.
I don't think the tone of these is quite right because in this path the player has chosen not to play the template. These should be encouraging the player to come back later and take a look.
| Template Elder: Thank you, StoryWeaver! The fabric of the world slowly heals! | ||
| Template Elder: Go forth: our world still needs your help. | ||
| => END | ||
| ~ no_quests |
There was a problem hiding this comment.
The elder.gd code assumes that the no_quests title exists:
threadbare/scenes/game_elements/characters/npcs/elder/components/elder.gd
Lines 111 to 112 in 4cd38e1
so please keep that one. (In practice it will never be reached, so I suggest keeping the existing line of dialogue.)
There was a problem hiding this comment.
I don't see any change here. I think this must be in a copy of the file you have made locally but not committed.
| % TemplateQuest Elder: We hope it sparks your imagination! | ||
| else: | ||
| Template Elder: We believe in you, StoryWeaver. Become the hero, and see where the path leads. | ||
| TemplateQuest Elder: Explore the template, adapt the story, and see where the path leads. |
There was a problem hiding this comment.
I think the coding style checker is going to complain about the use of spaces rather than tabs here.
edwardvilcamonje-max
changed the title
|
I’ve made the changes. Is everything okay now, or is there anything else I should change? |
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
As Will pointed out the lint check complains about the indentation type, using spaces instead of tabs:
scenes/game_elements/characters/npcs/elder/components/template_quest_starter.dialogue:
8-10: Wrong indentation type(spaces instead of tabs)
12: Wrong indentation type(spaces instead of tabs)
2 errors found
It's boring but is the way we have for ensuring the same formatting in all files instead of one developer preferring tabs, another dev preferring spaces, and having them change every time depending on who touched the file the last time. My recommendation is that you install pre-commit which will automatically fix this for you in most cases. Although not in this one. At least it will show you the error and won't let you commit.
| % TemplateQuest Elder: Take a look at this template. Perhaps it will inspire a story of your own! | ||
| % TemplateQuest Elder: This story is waiting to be explored, adapted, and brought to life! | ||
| % TemplateQuest Elder: We hope it sparks your imagination! | ||
| else:s |
There was a problem hiding this comment.
I tested it and it's interesting that the Dialogue Manager doesn't complain about this extra "s", not in syntax check or at runtime. But is not needed.
| else:s | |
| else: |
|
Please also adjust the PR description as requested above! |
| [ext_resource type="Script" uid="uid://du8wfijr35r35" path="res://scenes/game_elements/props/interact_area/interact_area.gd" id="3_ftke6"] | ||
| [ext_resource type="Script" uid="uid://edcifob4jc4s" path="res://scenes/game_logic/talk_behavior.gd" id="4_m4ftv"] | ||
| [ext_resource type="Resource" uid="uid://dg0fe4uwdjlbd" path="res://scenes/game_elements/characters/npcs/elder/components/template_quest_starter.dialogue" id="5_l4hfl"] | ||
| [ext_resource type="Resource" uid="uid://dg0fe4uwdjlbd" path="res://scenes/game_elements/characters/npcs/elder/components/template_quest_starter1.dialogue" id="5_l4hfl"] |
There was a problem hiding this comment.
It looks like you've copied the file, edited the copy, but then not committed the copy.
You should edit the original file, and restore this.
3 participants
Description
Created a new dialogue for the third Elder, the "TemplateQuest Elder", which offers Template StoryQuests separately from the StoryQuest Elder.
The dialogue makes it clear that these quests are templates intended to be explored, adapted, and developed by contributors. It encourages players to use the templates as inspiration and make the stories their own.
The new dialogue was added in the same directory and format as the existing Elder dialogue files.
resolver:#1102