Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
efeire
force-pushed
the
codex/schema-trigger-management
branch
from
October 24, 2026 09:20
0a9ebcf to
45ef19d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当前实现:feat(schema): manage Oracle-family triggers in existing object workflows
变更说明 / Change Description
补齐 Oracle 系触发器的完整管理闭环,复用树、对象浏览器、表结构、源码标签/弹窗、依赖和无效对象诊断入口。
变更类型 / Change Type
涉及前端 / Frontend Changes
OB Web GUI 已覆盖复杂源码保存、预览取消、撤销重做、启停/编译、INVALID 诊断与原稿修正、所属对象/依赖导航、分页、精确名称及删除取消/确认。全局远程搜索中的动作按物理身份执行;确认删除后移除搜索行,保留父表。
验证 / Validation
已记录的生产入口回归覆盖精确身份、复杂定义、分页/搜索、批量删除、取消、迟到响应和状态/错误读回;相关格式、lint、类型检查及构建有通过证据,独立规范/需求审查及必改增量复核已完成。
OceanBase Oracle 4.2.5.7_107 原生 Agent/JDBC API 与 Web GUI 工作流已验收,包括 disabled/VALID、成功回执仍 INVALID、编译错误及精确清理。该版本的嵌入双引号触发器名返回 INVALID/ORA-00900,边界空格名称被拒绝;保留原名和错误,不宣称此类名称可编译。
exact 混合读取保留 INDEX、TYPE/TYPE_BODY 与 TRIGGER 的身份、统一排序及分页,已有 Rust/JDBC 回归覆盖。本次主线适配仅做静态差异核对与独立规范/需求审查,未运行本地测试、类型检查、构建、GUI 或实库;历史运行证据仅用于未变范围。
当前提交的 CI 与自动审查以当前实现的 Checks 为准。
未测与暂缓: 原生 Oracle、DM8 实库及对应真实对象 GUI;原生 Desktop GUI。Windows H2 两项真实进程测试曾在外层 60 秒超时,错峰仍失败,未计通过;Linux CI 不消除该本机缺口。
make check、make cargo-check-fast未完整执行。包含主线 MCP Redis 错误文案的纯格式修正,以满足 Cargo fmt;不改变命令分派或权限行为。
Merge Danger
Door: one-way — 确认后的 DDL 可能已提交,代码回退不能撤销数据库修改;unknown/部分成功只读核实,不自动重放。
Blast Radius: Schema — Oracle 系触发器元数据、两套运输与现有交互入口;可选参数缺省保留旧合同。CI 依赖安装沿用主线共享脚本。