feat(schema): manage Oracle-family triggers in existing object workflows

Author: efeire

agents/common/src/main/java/com/dbx/agent/DatabaseAgent.java

@@ -86,6 +86,10 @@ default List<ObjectInfo> listObjects(String schema, MetadataListConstraints cons
         return MetadataListConstraints.orNone(constraints).filterObjects(listObjects(schema));
     }
 
+    default List<ObjectInfo> listObjects(String schema, MetadataListConstraints constraints, MetadataReadOptions options) {
+        return listObjects(schema, constraints);
+    }
+
     default List<String> listDataTypes() {
         return Collections.emptyList();
     }
@@ -104,6 +108,10 @@ default ObjectSource getObjectSource(String schema, String name, String objectTy
         throw new UnsupportedOperationException("Object source is not supported");
     }
 
+    default ObjectSource getObjectSource(String schema, String name, String objectType, MetadataReadOptions options) {
+        return getObjectSource(schema, name, objectType);
+    }
+
     default ObjectSource getObjectSourceWithOrigin(String schema, String name, String objectType) {
         return getObjectSource(schema, name, objectType);
     }
@@ -184,6 +192,10 @@ default List<ConstraintInfo> listConstraints(String schema, String table) {
 
     List<TriggerInfo> listTriggers(String schema, String table);
 
+    default List<TriggerInfo> listTriggers(String schema, String table, MetadataReadOptions options) {
+        return listTriggers(schema, table);
+    }
+
     default List<PartitionInfo> listPartitions(String schema, String table) {
         return Collections.emptyList();
     }

agents/common/src/main/java/com/dbx/agent/JsonRpcServer.java

@@ -253,6 +253,8 @@ private Object dispatch(String method, JsonObject params) throws Exception {
         }
         if (AgentProtocol.METHOD_LIST_OBJECTS.equals(method)) {
             switchCatalog(params);
+            MetadataReadOptions options = metadataReadOptions(params);
+            if (options.exact()) return agent.listObjects(params.get("schema").getAsString(), metadataListConstraints(params), options);
             return agent.listObjects(params.get("schema").getAsString(), metadataListConstraints(params));
         }
         if (AgentProtocol.METHOD_LIST_DATA_TYPES.equals(method)) {
@@ -265,13 +267,16 @@ private Object dispatch(String method, JsonObject params) throws Exception {
         }
         if (AgentProtocol.METHOD_GET_OBJECT_SOURCE.equals(method)) {
             switchCatalog(params);
+            MetadataReadOptions options = metadataReadOptions(params);
             boolean includeOrigin = params.has("include_source_origin") && params.get("include_source_origin").getAsBoolean();
             String schema = params.get("schema").getAsString();
             String name = params.get("name").getAsString();
             String objectType = params.get("object_type").getAsString();
-            ObjectSource source = includeOrigin
-                ? agent.getObjectSourceWithOrigin(schema, name, objectType)
-                : agent.getObjectSource(schema, name, objectType);
+            ObjectSource source = options.exact()
+                ? agent.getObjectSource(schema, name, objectType, options)
+                : includeOrigin
+                    ? agent.getObjectSourceWithOrigin(schema, name, objectType)
+                    : agent.getObjectSource(schema, name, objectType);
             if (includeOrigin) {
                 JsonObject result = gson.toJsonTree(source).getAsJsonObject();
                 if (source.getSourceOrigin() != null) {
@@ -303,6 +308,8 @@ private Object dispatch(String method, JsonObject params) throws Exception {
         }
         if (AgentProtocol.METHOD_LIST_TRIGGERS.equals(method)) {
             switchCatalog(params);
+            MetadataReadOptions options = metadataReadOptions(params);
+            if (options.exact()) return agent.listTriggers(params.get("schema").getAsString(), params.get("table").getAsString(), options);
             return agent.listTriggers(params.get("schema").getAsString(), params.get("table").getAsString());
         }
         if (AgentProtocol.METHOD_LIST_CONSTRAINTS.equals(method)) {
@@ -669,6 +676,15 @@ private MetadataListConstraints metadataListConstraints(JsonObject params) {
         );
     }
 
+    private static MetadataReadOptions metadataReadOptions(JsonObject params) {
+        String mode = stringOrNull(params, "identity_mode");
+        String alias = stringOrNull(params, "identityMode");
+        if (mode != null && alias != null && !mode.equals(alias)) {
+            throw new IllegalArgumentException("Conflicting metadata identity modes");
+        }
+        return MetadataReadOptions.fromIdentityMode(mode != null ? mode : alias);
+    }
+
     private static int intOrDefault(JsonObject object, String key, int defaultValue) {
         Integer value = intOrNull(object, key);
         return value == null ? defaultValue : value;

agents/common/src/main/java/com/dbx/agent/MetadataReadOptions.java

@@ -0,0 +1,13 @@
+package com.dbx.agent;
+
+/** Optional read semantics; accepting an option is not proof of provider support. */
+public record MetadataReadOptions(boolean exact) {
+    public static final MetadataReadOptions DEFAULT = new MetadataReadOptions(false);
+    public static final MetadataReadOptions EXACT = new MetadataReadOptions(true);
+
+    public static MetadataReadOptions fromIdentityMode(String mode) {
+        if (mode == null) return DEFAULT;
+        if ("exact".equals(mode)) return EXACT;
+        throw new IllegalArgumentException("Unsupported metadata identity mode");
+    }
+}

agents/common/src/main/java/com/dbx/agent/ObjectInfo.java

@@ -10,6 +10,7 @@ public final class ObjectInfo {
     private Boolean valid;
     private String parent_name;
     private String parent_schema;
+    private TriggerInfo trigger;
 
     public ObjectInfo() {
         this("", "", null, null, null);
@@ -71,14 +72,6 @@ public void setValid(Boolean valid) {
         this.valid = valid;
     }
 
-    public String getParent_name() {
-        return parent_name;
-    }
-
-    public void setParent_name(String parentName) {
-        this.parent_name = parentName;
-    }
-
     public String getParent_schema() {
         return parent_schema;
     }
@@ -87,6 +80,22 @@ public void setParent_schema(String parentSchema) {
         this.parent_schema = parentSchema;
     }
 
+    public TriggerInfo getTrigger() {
+        return trigger;
+    }
+
+    public void setTrigger(TriggerInfo trigger) {
+        this.trigger = trigger;
+    }
+
+    public String getParent_name() {
+        return parent_name;
+    }
+
+    public void setParent_name(String parentName) {
+        this.parent_name = parentName;
+    }
+
     @Override
     public boolean equals(Object other) {
         if (this == other) return true;
@@ -97,13 +106,14 @@ public boolean equals(Object other) {
             && Objects.equals(schema, that.schema)
             && Objects.equals(comment, that.comment)
             && Objects.equals(parent_name, that.parent_name)
+            && Objects.equals(valid, that.valid)
             && Objects.equals(parent_schema, that.parent_schema)
-            && Objects.equals(valid, that.valid);
+            && Objects.equals(trigger, that.trigger);
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(name, object_type, schema, comment, valid, parent_name, parent_schema);
+        return Objects.hash(name, object_type, schema, comment, valid, parent_name, parent_schema, trigger);
     }
 
     @Override

agents/common/src/main/java/com/dbx/agent/ObjectSource.java

@@ -8,6 +8,7 @@ public final class ObjectSource {
     private String schema;
     private String source;
     private boolean editable;
+    private TriggerInfo trigger;
     private transient String sourceOrigin;
 
     public ObjectSource() {
@@ -78,6 +79,14 @@ public void setEditable(boolean editable) {
         this.editable = editable;
     }
 
+    public TriggerInfo getTrigger() {
+        return trigger;
+    }
+
+    public void setTrigger(TriggerInfo trigger) {
+        this.trigger = trigger;
+    }
+
     @Override
     public boolean equals(Object other) {
         if (this == other) return true;
@@ -87,12 +96,13 @@ public boolean equals(Object other) {
             && Objects.equals(object_type, that.object_type)
             && Objects.equals(schema, that.schema)
             && Objects.equals(source, that.source)
-            && editable == that.editable;
+            && editable == that.editable
+            && Objects.equals(trigger, that.trigger);
     }
 
     @Override
     public int hashCode() {
-        return Objects.hash(name, object_type, schema, source, editable);
+        return Objects.hash(name, object_type, schema, source, editable, trigger);
     }
 
     @Override

agents/common/src/main/java/com/dbx/agent/OracleTriggerMetadata.java

@@ -0,0 +1,17 @@
+package com.dbx.agent;
+
+import java.util.List;
+import java.util.Map;
+
+/** Raw dictionary identity. Missing fields remain unknown, not false or empty. */
+public record OracleTriggerMetadata(
+    int contractVersion, String identityMode, String engine, String engineVersion,
+    String owner, String name, String scope, String scopeType, String scopeOwner,
+    Parent parent, String objectId, String lastDdlTime, Definition definition,
+    List<CompilationError> errors, Map<String, ReadState> reads
+) {
+    public record Parent(String owner, String name, String objectType, String objectId) {}
+    public record Definition(String origin, String format, boolean complete) {}
+    public record CompilationError(long sequence, long line, long position, String text, String severity) {}
+    public record ReadState(String state, String message) {}
+}