Protect isMergeable() from types with no dictionary#51230
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51230/49800 |
|
A new Pull Request was created by @dan131riley for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
Thanks Dan! |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
Comparison differences are related to #47071 |
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Reading pre-20xx files in 20xx can segfault in the check for mergable run and lumi products in the case where there is no dictionary for the product being checked. Sample stack trace:
Background in #51199 (comment).
Job failure in this case is expected, since #50968 breaks backward compatibility. However, the job should not segfault.
PR validation:
With this PR, sample failing jobs fail with a proper exception:
A limited matrix run (in progress) has found no problems introduced by this PR.
Resolves cms-sw/framework-team#2301