Updates L1T OMTF for Phase 2 by mbluj · Pull Request #50032 · cms-sw/cmssw

mbluj · 2026-02-04T13:57:27Z

PR description:

This PR introduces recent (as for beginning of 2026) changes in the L1T OMTF emulator for Phase2:

Algorithm adapted to the latest DT TPs;
Output candidates are returned as SAMuons (Phase 2 data format):
- Conversion to the Phase 2 scales is implemented;
- Some code refactoring was needed: an internal class FinalMuon was introduced that stores the candidate parameters in the output format. It can be either Phase 1 or Phase 2 scales. Then it is converted to RegionalMuonCands (Phase 1) or SAMuons (Phase 2);
Improvements and refactoring of CandidateSimMuonMatcher and DataROOTDumper2 used for developments and validations.

In addition the PR contains a fix of bugs found in DTTriggerPhase2 which are already included in #49589, but as it is not merged yet added here for self-consistency.

Details in this JIRA ticket and K. Bunkowski's presentation here.

This PR requires updated configuration files provided in cms-data/L1Trigger-L1TMuon#29.

PR validation:

Validated with Phase 2 workflows, e.g. 23634.0.

FYI, @akalinow, @kbunkow

cmsbuild · 2026-02-04T13:58:04Z

cms-bot internal usage

cmsbuild · 2026-02-04T14:00:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/47864

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): [L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

cmsbuild · 2026-02-04T14:00:48Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

L1Trigger/DTTriggerPhase2 (l1)
L1Trigger/L1TMuonOverlapPhase1 (l1)
L1Trigger/L1TMuonOverlapPhase2 (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

quinnanm · 2026-02-04T21:47:52Z

please test

cmsbuild · 2026-02-04T21:54:55Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/51110/summary.html
COMMIT: 255348b
CMSSW: CMSSW_16_1_X_2026-02-04-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50032/51110/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

mbluj · 2026-02-05T14:20:47Z

Fixed issue found in tests with clang.

cmsbuild · 2026-02-05T14:22:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/47899

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc modified in PR(s): [L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

cmsbuild · 2026-02-05T14:23:19Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

mbluj · 2026-02-05T14:23:20Z

Please test this PR with cms-data/L1Trigger-L1TMuon#29.

mbluj · 2026-02-09T12:04:34Z

I'd like to ask to start tests and eventually the review, thank you.

…of cast from float to int

The bug has had no impact as it was part of the final, redundant condition in an "else if" statement

e.g. better use of const, cout=>MessageLogs, additional comments, etc.

OMTFProcessor.cc and OmtfProcessorPhase2.cc Fixing the condition to assign minimum pT (0 or 1 GeV) for the muons that have only unconstrained pt valid. Checking getFiredLayerCntConstr was missing. updating runMuonOverlap_run3_mc.py and runMuonOverlap.py

RegionalMuonCandBxCollection is no longer produced by L1TMuonOverlapPhase2TrackProducer, RegionalMuonCand are not created by the OmtfEmulation. Only SAMuonCollection (OMTFconstr and OMTFunconstr) are produced now. L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc was modified to avoid using RegionalMuonCand and instead use SAMuon from OMTF. L1Trigger/L1TMuonOverlapPhase1/src/Omtf/OMTFConfiguration.cc: fix in procPhiOmtfToGlobalPhiOmtf

mbluj · 2026-06-23T10:13:52Z

The PR was updated implementing review comments and rebased to a newer IB of 21 June.

cmsbuild · 2026-06-23T10:14:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/49898

cmsbuild · 2026-06-23T10:14:18Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

BenjaminRS · 2026-06-26T10:04:46Z

please test

cmsbuild · 2026-06-26T12:48:43Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/54304/summary.html
COMMIT: 6e361a2
CMSSW: CMSSW_20_1_X_2026-06-25-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50032/54304/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@Annnnya Fix edmMpiConfigSplitter logic when grouping with dublicated modules #51318

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/54304/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/54304/git-merge-result

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3561929
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3561891
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 200 log files, 167 edm output root files, 46 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 2025.0010001_RunJetMET02025C_10k step2 max memory diff -33.7 exceeds +/- 30.0 MiB

BenjaminRS

I think we can approve this PR as is. But we would like a further PR to tidy up the code a bit more

BenjaminRS · 2026-06-26T10:46:44Z

+     #'/store/express/Commissioning2021/ExpressCosmics/FEVT/Express-v1/000/344/266/00000/db2cfbdd-5edf-4ee4-aab0-5bdba105728d.root' #DT and RPC fw 0x0008
     #'/store/express/Commissioning2021/ExpressCosmics/FEVT/Express-v1/000/344/566/00000/19ef107a-4cd9-4df0-ba93-dbfbab8df1cb.root'  
     #'/store/express/Commissioning2021/ExpressCosmics/FEVT/Express-v1/000/347/053/00000/7b486245-96ea-4b7c-9fe7-76c957968785.root'  #RPC noise only
+     'file:/eos/home-k/kbunkow/cms_data/run3_data/Run2025G_398240_Muon0_raw.root'


I think we can leave it for now, but better to have these sort of files in some central EOS/L1T area

BenjaminRS · 2026-06-26T14:19:14Z

 #process.load('Configuration.StandardSequences.RawToDigi_Data_cff')
 #process.load('EventFilter.L1TRawToDigi.omtfStage2Digis_cfi') #unpacker

 #process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')


In a future PR can we clear up the commented out code please?

BenjaminRS · 2026-06-30T09:42:18Z

 #process.load('Configuration.EventContent.EventContent_cff')
 #process.load('SimGeneral.MixingModule.mixNoPU_cfi')
-process.load('Configuration.Geometry.GeometryExtendedRun4D95Reco_cff')
+process.load('Configuration.Geometry.GeometryExtendedRun4D110Reco_cff')


Geometries should be D121 now

BenjaminRS · 2026-06-30T09:42:39Z

 #process.load('Configuration.EventContent.EventContent_cff')
 #process.load('SimGeneral.MixingModule.mixNoPU_cfi')
-process.load('Configuration.Geometry.GeometryExtendedRun4D95Reco_cff')
+process.load('Configuration.Geometry.GeometryExtendedRun4D110Reco_cff')


BenjaminRS · 2026-06-30T09:43:10Z

+              {"path": "/eos/user/a/akalinow/Data/SingleMu/12_5_2_p1_04_04_2023/SingleMu_ch0_iPt2_12_5_2_p1_04_04_2023/", "fileCnt" : 500}, #500 files
+              {"path": "/eos/user/a/akalinow/Data/SingleMu/12_5_2_p1_04_04_2023/SingleMu_ch2_iPt2_12_5_2_p1_04_04_2023/", "fileCnt" : 500}, #500 files


Better to use a L1T/Muon EOS space

BenjaminRS · 2026-06-30T09:44:36Z

+#process.load('FWCore.MessageService.MessageLogger_cfi')
+#process.load('Configuration.EventContent.EventContent_cff')
+#process.load('SimGeneral.MixingModule.mixNoPU_cfi')
+process.load('Configuration.Geometry.GeometryExtendedRun4D110Reco_cff')


BenjaminRS · 2026-06-30T10:53:54Z

+l1

cmsbuild · 2026-06-30T10:54:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TMuon#29

mbluj · 2026-06-30T11:05:43Z

Thank you @BenjaminRS.
Should we quickly fix overlooked typo outptu -> output and the D110 to D121 geometry in test python configs?

BenjaminRS · 2026-06-30T11:08:58Z

@mbluj - I think you can do this in a follow up PR. For the Geometries, did you choose those due to a specific file you were using that was e.g. created with D110?

mbluj · 2026-06-30T11:24:36Z

@mbluj - I think you can do this in a follow up PR. For the Geometries, did you choose those due to a specific file you were using that was e.g. created with D110?

I would push these "cosmetic" changes here, but fine if you prefer to include them to a bigger cleaning PR. Anyway, I will fix the typo in the 170X backport PR.

As for geometry: the one used was recommended when the files were created in a private development area, but OMTF output is almost insensitive on this. Updating to the current default makes sense.

BenjaminRS · 2026-06-30T11:43:23Z

OK - lets just quickly change here then and we can re-test and sign today

…space, etc.

…n to match those defined in the upstream producer

cmsbuild · 2026-06-30T12:05:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50032/50027

cmsbuild · 2026-06-30T12:05:40Z

Pull request #50032 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

BenjaminRS · 2026-06-30T12:12:07Z

please test

cmsbuild · 2026-06-30T14:52:49Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e571da/54410/summary.html
COMMIT: a001c62
CMSSW: CMSSW_20_1_X_2026-06-30-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50032/54410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3561929
DQMHistoTests: Total failures: 44
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3561867
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 200 log files, 167 edm output root files, 46 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 2025.0010001_RunJetMET02025C_10k step2 max memory diff -33.7 exceeds +/- 30.0 MiB

BenjaminRS · 2026-06-30T14:55:25Z

+l1

cmsbuild · 2026-06-30T14:55:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TMuon#29

ftenchini · 2026-07-01T07:58:16Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Feb 4, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 4, 2026

mbluj mentioned this pull request Feb 4, 2026

Updated configuration of OMTF for Phase2 cms-data/L1Trigger-L1TMuon#29

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2026

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Feb 4, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 5, 2026

cmsbuild mentioned this pull request Feb 10, 2026

[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3 #49589

Merged

mbluj and others added 6 commits June 22, 2026 13:08

technical: removal of unused counters and explicite rounding instead …

338ccac

…of cast from float to int

Fix of a logical bug

415c574

The bug has had no impact as it was part of the final, redundant condition in an "else if" statement

Code cleaning and fixes,

1422f14

e.g. better use of const, cout=>MessageLogs, additional comments, etc.

Sync with 201X release series

bd61b8c

mbluj mentioned this pull request Jun 23, 2026

Updates L1T OMTF for Phase 2 [17_0_X] #51296

Merged

BenjaminRS approved these changes Jun 30, 2026

View reviewed changes

mbluj added 3 commits June 30, 2026 13:52

Code style, e.g. fixed typos in names, consistent use of the std name…

9b4c874

…space, etc.

Set names of the OMTF digis instances in the autogenerated descriptio…

9297b1f

…n to match those defined in the upstream producer

Update geometries in test configurations

a001c62

mbluj mentioned this pull request Jul 13, 2026

Updates L1T OMTF for Phase 2 [20_0_X] #51474

Open

		{"path": "/eos/user/a/akalinow/Data/SingleMu/12_5_2_p1_04_04_2023/SingleMu_ch0_iPt2_12_5_2_p1_04_04_2023/", "fileCnt" : 500}, #500 files
		{"path": "/eos/user/a/akalinow/Data/SingleMu/12_5_2_p1_04_04_2023/SingleMu_ch2_iPt2_12_5_2_p1_04_04_2023/", "fileCnt" : 500}, #500 files

Uh oh!

Conversation

mbluj commented Feb 4, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

quinnanm commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Failed Clang Build

Uh oh!

mbluj commented Feb 5, 2026

Uh oh!

cmsbuild commented Feb 5, 2026

Uh oh!

cmsbuild commented Feb 5, 2026

Uh oh!

mbluj commented Feb 5, 2026

Uh oh!

mbluj commented Feb 9, 2026

Uh oh!

mbluj commented Jun 23, 2026

Uh oh!

cmsbuild commented Jun 23, 2026

Uh oh!

cmsbuild commented Jun 23, 2026

Uh oh!

BenjaminRS commented Jun 26, 2026

Uh oh!

cmsbuild commented Jun 26, 2026

Comparison Summary

Max Memory Comparisons exceeding threshold

Uh oh!

BenjaminRS left a comment

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenjaminRS Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminRS Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BenjaminRS commented Jun 30, 2026

Uh oh!

cmsbuild commented Jun 30, 2026

Uh oh!

mbluj commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenjaminRS commented Jun 30, 2026

Uh oh!

mbluj commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenjaminRS commented Jun 30, 2026

Uh oh!

cmsbuild commented Jun 30, 2026

cmsbuild commented Feb 4, 2026 •

edited

Loading

mbluj commented Jun 30, 2026 •

edited

Loading

mbluj commented Jun 30, 2026 •

edited

Loading