Skip to content

Fixed Uninitialized warnings for RecoTracker in ASAN IBs #50240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Mar 25, 2026
Merged

Fixed Uninitialized warnings for RecoTracker in ASAN IBs #50240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions RecoTracker/LSTCore/src/alpaka/Quadruplet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,20 +254,12 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE::lst {
error2 = moduleTypei == 0 ? kPixelPSZpitch * kPixelPSZpitch : kStrip2SZpitch * kStrip2SZpitch;

//check the tilted module, side: PosZ, NegZ, Center(for not tilted)
float drdz;
short side, subdets;
if (i == 2) {
drdz = alpaka::math::abs(acc, modules.drdzs()[lowerModuleIndex2]);
side = modules.sides()[lowerModuleIndex2];
subdets = modules.subdets()[lowerModuleIndex2];
}
if (i == 3) {
drdz = alpaka::math::abs(acc, modules.drdzs()[lowerModuleIndex3]);
side = modules.sides()[lowerModuleIndex3];
subdets = modules.subdets()[lowerModuleIndex3];
}
const bool isEndcapOrCenter = (subdets == lst::Endcap) or (side == lst::Center);
if (i == 2 || i == 3) {
uint16_t moduleIndex = (i == 2) ? lowerModuleIndex2 : lowerModuleIndex3;
float drdz = alpaka::math::abs(acc, modules.drdzs()[moduleIndex]);
short side = modules.sides()[moduleIndex];
short subdets = modules.subdets()[moduleIndex];
const bool isEndcapOrCenter = (subdets == lst::Endcap) or (side == lst::Center);
residual = (layeri <= 6 && ((side == Center) or (drdz < 1))) ? diffz : diffr;
float projection_missing2 = 1.f;
if (drdz < 1)
Expand Down