Fixed Uninitialized warnings for RecoTracker in ASAN IBs by akritkbehera · Pull Request #50240 · cms-sw/cmssw

akritkbehera · 2026-02-24T12:03:24Z

There are few uninitialized warnings in ASAN IBs this PR addresses that

[src/RecoTracker/LSTCore/src/alpaka/Quadruplet.h:269](https://github.com/cms-sw/cmssw/blob/CMSSW_16_1_ASAN_X_2026-02-23-2300/RecoTracker/LSTCore/src/alpaka/Quadruplet.h#L269):71: warning: 'side' may be used uninitialized [-Wmaybe-uninitialized]
   269 |       const bool isEndcapOrCenter = (subdets == lst::Endcap) or (side == lst::Center);
[src/RecoTracker/LSTCore/src/alpaka/Quadruplet.h:269:46: warning: 'subdets' may be used uninitialized [-Wmaybe-uninitialized]
   269 |       const bool isEndcapOrCenter = (subdets == lst::Endcap) or (side == lst::Center);
[src/RecoTracker/LSTCore/src/alpaka/Quadruplet.h:271:54: warning: 'drdz' may be used uninitialized [-Wmaybe-uninitialized]
   271 |         residual = (layeri <= 6 && ((side == Center) or (drdz < 1))) ? diffz : diffr;

cmsbuild · 2026-02-24T12:03:43Z

cms-bot internal usage

cmsbuild · 2026-02-24T12:05:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50240/48228

cmsbuild · 2026-02-24T12:05:32Z

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

RecoTracker/LSTCore (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

akritkbehera · 2026-02-24T12:06:22Z

please test for CMSSW_16_1_ASAN_X

cmsbuild · 2026-02-24T12:34:36Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/51554/summary.html
COMMIT: 006371b
CMSSW: CMSSW_16_1_ASAN_X_2026-02-23-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50240/51554/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/51554/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/51554/git-merge-result

Failed Build

I found compilation error when building:

>> Subsystem Configuration built
Copying tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a': No such file or directory
Copying tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a to productstore area:
>> Deleted: tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a] Error 1
cp: cannot stat 'tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a] Error 1
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
Copying tmp/el8_amd64_gcc13/src/RecoLocalCalo/HGCalRecAlgos/plugins/RecoLocalCaloHGCalRecAlgosPluginsPortableROCmAsync/libRecoLocalCaloHGCalRecAlgosPluginsPortableROCmAsync_rocm.a to productstore area:

Static analyzer reported errors, please check

akritkbehera · 2026-02-24T12:55:41Z

please test with cms-sw/cmsdist#10371 for CMSSW_16_1_ASAN_X

cmsbuild · 2026-02-24T12:56:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50240/48229

cmsbuild · 2026-02-24T12:56:51Z

Pull request #50240 was updated. @Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

cmsbuild · 2026-03-19T12:22:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50240/48611

cmsbuild · 2026-03-19T12:22:59Z

Pull request #50240 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

akritkbehera · 2026-03-19T12:24:46Z

Please test

cmsbuild · 2026-03-19T15:57:36Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52096/summary.html
COMMIT: c0011d5
CMSSW: CMSSW_16_1_X_2026-03-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50240/52096/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52096/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52096/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testMPIAutosplitter had ERRORS

Comparison Summary

Summary:

You potentially removed 195 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 20738 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4418697
DQMHistoTests: Total failures: 3158
DQMHistoTests: Total nulls: 23
DQMHistoTests: Total successes: 4415496
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 23.262 KiB( 54 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 6.585 KiB HLT/ScoutingOffline
DQMHistoSizes: changed ( 2024.0000001,... ): -0.381 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 2024.0000001 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0010001 ): -0.020 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0020001 ): -0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0040001 ): -0.062 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0050001 ): 0.035 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0060001 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 2024.0070001 ): 0.004 KiB JetMET/SUSYDQM
Checked 235 log files, 208 edm output root files, 55 DQM output files
TriggerResults: found differences in 3 / 53 workflows

akritkbehera · 2026-03-20T08:07:56Z

please test for CMSSW_16_1_ASAN_X

cmsbuild · 2026-03-20T12:40:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52112/summary.html
COMMIT: c0011d5
CMSSW: CMSSW_16_1_ASAN_X_2026-03-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50240/52112/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52112/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52112/git-merge-result

jfernan2 · 2026-03-23T08:51:14Z

please test

cmsbuild · 2026-03-23T11:41:50Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797362/52145/summary.html
COMMIT: c0011d5
CMSSW: CMSSW_16_1_X_2026-03-22-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50240/52145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4418773
DQMHistoTests: Total failures: 75
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4418678
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
Checked 235 log files, 208 edm output root files, 55 DQM output files
TriggerResults: no differences found

jfernan2 · 2026-03-24T10:45:47Z

+1

cmsbuild · 2026-03-24T10:46:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-03-25T07:43:48Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Feb 24, 2026

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Feb 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2026

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Feb 24, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Feb 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 19, 2026

cmsbuild added tests-started and removed tests-pending labels Mar 19, 2026

cmsbuild added tests-rejected and removed tests-started labels Mar 19, 2026

cmsbuild added tests-started and removed tests-rejected labels Mar 23, 2026

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2026

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Mar 24, 2026

cmsbuild added orp-approved and removed orp-pending labels Mar 25, 2026

cmsbuild merged commit 56de03c into cms-sw:master Mar 25, 2026
16 checks passed

This was referenced Mar 25, 2026

[AllocMonitorPlugin][GCC15] Link stdc++exp for gcc14 abd above #50541

Merged

llvm: Drop libcxx, libcxxabi, libunwind runtime as we use gcc-toolchain cms-sw/cmsdist#10442

Merged

Uh oh!

Conversation

akritkbehera commented Feb 24, 2026

Uh oh!

cmsbuild commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 24, 2026

Uh oh!

cmsbuild commented Feb 24, 2026

Uh oh!

akritkbehera commented Feb 24, 2026

Uh oh!

cmsbuild commented Feb 24, 2026

Failed Build

Uh oh!

akritkbehera commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 24, 2026

Uh oh!

cmsbuild commented Feb 24, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Uh oh!

akritkbehera commented Mar 19, 2026

Uh oh!

cmsbuild commented Mar 19, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

akritkbehera commented Mar 20, 2026

Uh oh!

cmsbuild commented Mar 20, 2026

Uh oh!

jfernan2 commented Mar 23, 2026

Uh oh!

cmsbuild commented Mar 23, 2026

Comparison Summary

Uh oh!

jfernan2 commented Mar 24, 2026

Uh oh!

cmsbuild commented Mar 24, 2026

Uh oh!

mandrenguyen commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Feb 24, 2026 •

edited

Loading

akritkbehera commented Feb 24, 2026 •

edited

Loading