Optionally read symbol prompts via completing-read#4117
Merged
Conversation
bbatsov
force-pushed
the
prototype-symbol-completing-read
branch
from
July 18, 2026 17:54
c6104c3 to
c1465db
Compare
Symbol prompts (cider-doc, cider-find-var, ...) read through cider-read-from-minibuffer, which uses completion-at-point rather than completing-read, so completing-read UIs (Vertico, Ivy, Helm) don't apply there. Historically we couldn't switch to completing-read because it wants the full candidate collection up front and we can't dump every symbol. A dynamic collection sidesteps that: cider-completing-read-symbol reads via completing-read over a table that queries the complete op lazily per input, caches per input, annotates candidates with type/ns, and only starts querying past cider-completion-symbol-prompt-min-length chars so an empty prompt never asks for every symbol. Gated behind cider-use-completing-read-for-symbol (off by default) while the behavior settles.
bbatsov
force-pushed
the
prototype-symbol-completing-read
branch
from
July 23, 2026 15:34
c1465db to
6f6f808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIDER's symbol prompts (
cider-doc,cider-find-var, and friends when there's no symbol at point) read throughcider-read-from-minibuffer, which usescompletion-at-pointrather thancompleting-read. Socompleting-readUIs like Vertico, Ivy and Helm don't apply there, and you get the old TAB/*Completions*behavior instead of your usual narrowing UI. We couldn't switch tocompleting-readin the past because it wants the whole candidate list up front and we can't dump every symbol.A dynamic collection gets us there:
cider-completing-read-symbolreads viacompleting-readover a table that queries thecompleteop lazily per input, caches per input, annotates candidates with their type/namespace, and only starts querying once the input reachescider-completion-symbol-prompt-min-lengthchars (2), so an empty prompt never asks the runtime for every symbol.It's gated behind
cider-use-completing-read-for-symbol, off by default for now. Verified against a live REPL (lazy querying, the min-length guard, namespaced candidates, annotations, per-input caching) and covered by tests. Docs are in the code-completion page, including a note on eldoc-in-the-prompt behavior.Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.