Add aligned completion annotations via affixation-function#4129
Merged
Conversation
Provide an `affixation-function' (`cider-affixate-symbol') alongside the existing `annotation-function', so completion UIs that support it (the built-in `*Completions*', Corfu, Vertico) render the type/namespace info as an aligned column instead of a ragged trailing string; company keeps using the annotation function. Also fold the capf table and the completing-read symbol table onto a shared `cider--completion-table' builder (they had duplicated the metadata / `complete-with-action' skeleton), drop a no-op `with-current-buffer', and refresh comments that described the capf as company-only (corfu consumes the same `:company-*' properties).
bbatsov
force-pushed
the
modernize-completion-annotations
branch
from
July 23, 2026 16:17
5c1991b to
ea99557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernization pass on
cider-completion.el:affixation-function(cider-affixate-symbol) next to the existingannotation-function. UIs that support it (built-in*Completions*, Corfu, Vertico) now render the type/namespace as an aligned column rather than a ragged suffix; company keeps using the annotation function.completing-readsymbol table onto a sharedcider--completion-tablebuilder — they had duplicated the metadata /complete-with-actionskeleton (the second was added in Optionally read symbol prompts via completing-read #4117).with-current-buffer, and refresh comments that called the capf company-only (corfu consumes the same:company-*properties).No behavior change to matching or candidate sourcing. First slice of a broader completion modernization.