Adds shutdown to Plugin - #1902
Open
NotStirred wants to merge 16 commits into
Open
Conversation
Closes chunky-dev#1893 - Allows chunky to close them on shutdown without a System.exit() - Additionally provides an api to wait on all chunky threads to be joined.
And hopefully be more readable
The comment already explains that the worst case cannot take more cycles than the number of plugins to load, so we use that.
NotStirred
force-pushed
the
feature/plugin_shutdown
branch
from
July 26, 2026 20:27
fbaf23c to
f45cc1d
Compare
NotStirred
force-pushed
the
feature/plugin_shutdown
branch
from
July 26, 2026 20:30
f45cc1d to
a1b164d
Compare
This was referenced Jul 26, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1895 (adds 3 commits). Use this diff (1895..this) for review
Shuts down plugins in the opposite order to when they were loaded.
Also: