Bedrock support - #1906
Draft
NotStirred wants to merge 60 commits into
Draft
Conversation
all are now abstract
# Conflicts: # chunky/src/java/se/llbit/chunky/world/EmptyWorld.java
# Conflicts: # chunky/src/java/se/llbit/chunky/world/EmptyWorld.java
Closes chunky-dev#1893 - Allows chunky to close them on shutdown without a System.exit() - Additionally provides an api to wait on all chunky threads to be joined.
And hopefully be more readable
The comment already explains that the worst case cannot take more cycles than the number of plugins to load, so we use that.
…g latest.json file.
This means the map view shows empty white stripes, not a black void.
It had the potential to allow RegionParser threads to call getChunk on a dimension with a closed DB.
NotStirred
force-pushed
the
feature/bedrock
branch
from
July 29, 2026 16:05
d33812a to
9f4de5f
Compare
Member
Author
|
Latest commits fix all of the issues with world loading I know about (compare against first image). The missing chunk holes are expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not attempt to handle any of the block NBT differences between java and bedrock. As such many non-trivial blocks are
?.Additionally some blocks appear in the wrong place (water, some tall grass), seems to be heightmap related but I haven't investigated.
This PR is based on a lot of open PRs,
Before-merge checklist:
org.cloudburstmc:nbtAll that said, it's getting there:
