[WIP] Track WCH CH5xx and CH32V4x7 support

.cargo/config.toml

@@ -1,5 +1,5 @@
 [alias]
 xtask = "run --package xtask --"
-probe-rs = "run --package probe-rs-tools --bin probe-rs --features remote --"
+probe-rs = "run --package probe-rs-tools --bin probe-rs --"
 smoke-tester = "test --package smoke_tester --"
 target-gen = "run --package target-gen --release --"

.github/workflows/changelog.yml

@@ -21,7 +21,7 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - uses: swatinem/rust-cache@v2
         with:

.github/workflows/ci.yml

@@ -39,10 +39,10 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - name: cargo check for probe-rs, --no-default-features
         run: cargo check -p probe-rs --no-default-features --locked
@@ -71,13 +71,13 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: "Install thumbv7m-none-eabi target for tests"
         run: rustup target add thumbv7m-none-eabi
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - uses: taiki-e/install-action@nextest
 
@@ -89,7 +89,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Run cargo fmt
         run: cargo fmt --all -- --check
@@ -99,29 +99,44 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - name: Run cargo clippy
         run: cargo clippy --all-features --all-targets --locked -- -D warnings
 
   cargo-deny:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - uses: EmbarkStudios/cargo-deny-action@v2
 
+  typos:
+    name: Typos
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: crate-ci/typos@main
+
+  machete:
+    name: Unused dependencies
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: taiki-e/install-action@cargo-machete
+      - run: cargo machete
+
   doc:
     name: Check docs
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - name: Run cargo doc
         run: cargo doc -p probe-rs --no-deps --all-features --locked
@@ -133,10 +148,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - uses: taiki-e/install-action@cargo-hack
 

.github/workflows/release_crates.yml

@@ -20,7 +20,7 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           fetch-depth: 0 # This is a workaround for cargo-release, see https://github.com/crate-ci/cargo-release/issues/625
           # We need to manually set a token here to ensure that we can trigger the `cargo dist` workflow.
@@ -94,3 +94,12 @@ jobs:
           echo "::endgroup::"
         env:
           SSH_AUTH_SOCK: /tmp/ssh_agent.sock
+
+      # dist releases run on workflow_dispatch (dispatch-releases), so kick off
+      # the build for the tag we just pushed.
+      - name: Trigger the release build
+        run: gh workflow run v-release.yml --ref "$RELEASE_BRANCH" -f tag="v$VERSION"
+        env:
+          GH_TOKEN: ${{ secrets.GH_PAT }}
+          RELEASE_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref || github.ref_name }}
+          VERSION: ${{ steps.crate_version.outputs.version }}

.github/workflows/release_dry_run.yml

@@ -0,0 +1,75 @@
+# Dry-runs a release on PRs labelled 'release': a crates.io publish dry-run, plus
+# the full dist build (dispatched as a dry-run of the release workflow). Catches
+# publish/build/runner problems on the release PR instead of when we cut the
+# release. Nothing is published, tagged or pushed.
+
+on:
+  pull_request:
+    branches: [master, release/**]
+    types: [opened, reopened, synchronize, labeled]
+  workflow_dispatch:
+
+name: Release dry-run
+
+jobs:
+  publish:
+    name: Dry-run publish
+    runs-on: ubuntu-latest
+    if: github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'release')
+    steps:
+      - uses: actions/checkout@v7
+      - uses: taiki-e/install-action@cargo-release
+      # Use cargo-release (not `cargo publish --dry-run`) so the dry-run runs the
+      # exact checks the real release does: metadata validation (missing
+      # description etc.) plus the verification build. --allow-branch lets it run
+      # on the release PR branch; leaving off --execute keeps it a dry-run.
+      - run: cargo release publish --no-confirm --allow-branch '*'
+
+  # Run the real dist build (all targets) as a dry-run without copying dist's
+  # workflow: dispatch it against this PR's branch and watch it, so this job's
+  # pass/fail mirrors the build and shows up as a check on the PR.
+  build:
+    name: Dry-run build
+    runs-on: ubuntu-latest
+    if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'release')
+    steps:
+      - name: Dispatch and watch the dist dry-run build
+        run: |
+          before=$(gh run list --repo "$GITHUB_REPOSITORY" --workflow=v-release.yml --branch "$HEAD" --limit 1 --json databaseId --jq '.[0].databaseId // 0')
+          gh workflow run v-release.yml --repo "$GITHUB_REPOSITORY" --ref "$HEAD" -f tag=dry-run
+
+          # Wait for the new run to appear.
+          run_id=0
+          for _ in $(seq 1 30); do
+            run_id=$(gh run list --repo "$GITHUB_REPOSITORY" --workflow=v-release.yml --branch "$HEAD" --limit 1 --json databaseId --jq '.[0].databaseId // 0')
+            [ "$run_id" != "$before" ] && break
+            sleep 5
+          done
+          echo "Watching run $run_id"
+
+          # Poll until the run finishes. The build jobs sit "queued" while `plan`
+          # runs (they need it), so only start the runner clock once plan is done:
+          # a healthy runner attaches within a minute, so if a build job is still
+          # queued 1 min after that, no runner is coming -> abort.
+          # Judging by the final conclusion means an API hiccup can't fail a green build.
+          plan_done=0
+          while :; do
+            info=$(gh run view "$run_id" --repo "$GITHUB_REPOSITORY" --json status,jobs)
+            if [ "$(jq -r .status <<<"$info")" = "completed" ]; then break; fi
+            plan_status=$(jq -r '.jobs[] | select(.name == "plan") | .status' <<<"$info")
+            if [ "$plan_status" = "completed" ] && [ "$plan_done" = 0 ]; then plan_done=$(date +%s); fi
+            stuck=$(jq '[.jobs[] | select(.name != "plan" and .status == "queued")] | length' <<<"$info")
+            if [ "$plan_done" != 0 ] && [ "$stuck" -gt 0 ] && [ "$(( $(date +%s) - plan_done ))" -gt 60 ]; then
+              echo "::error::a dist build job got no runner within 1 min of plan completing:"
+              jq -r '.jobs[] | select(.name != "plan" and .status == "queued") | "  - " + .name' <<<"$info"
+              gh run cancel "$run_id" --repo "$GITHUB_REPOSITORY" || true
+              exit 1
+            fi
+            sleep 20
+          done
+          result=$(gh run view "$run_id" --repo "$GITHUB_REPOSITORY" --json conclusion --jq .conclusion)
+          echo "dist dry-run build: $result"
+          [ "$result" = "success" ]
+        env:
+          GH_TOKEN: ${{ secrets.GH_PAT }}
+          HEAD: ${{ github.head_ref }}

.github/workflows/smoketest.yml

@@ -2,6 +2,7 @@ on:
   push:
     branches: [master, staging, trying]
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   merge_group:
   workflow_dispatch:
 
@@ -10,29 +11,27 @@ name: Run smoke test
 env:
   CARGO_INCREMENTAL: 0
 
-# Cancel any currently running workflows from the same PR, branch, or
-# tag when a new workflow is triggered.
-#
-# https://stackoverflow.com/a/66336834
-concurrency:
-  cancel-in-progress: true
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-
 jobs:
   build-smoke-tester:
+    # Skip the slow hardware tests on draft PRs.
+    if: ${{ !github.event.pull_request.draft }}
     runs-on: ubuntu-24.04-arm
+    # A new run of the same PR, branch, or tag cancels this job.
+    concurrency:
+      cancel-in-progress: true
+      group: ${{ github.workflow }}-build-smoke-tester-${{ github.event.pull_request.number || github.ref }}
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Install target for cross-compilation
         run: rustup target add aarch64-unknown-linux-musl
 
       - uses: taiki-e/install-action@nextest
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - name: Show rust info
         run: rustup show
@@ -46,25 +45,30 @@ jobs:
           path: smoke_tester.tar.zst
 
   build-probe-rs:
+    if: ${{ !github.event.pull_request.draft }}
     runs-on: ubuntu-latest
+    # A new run of the same PR, branch, or tag cancels this job.
+    concurrency:
+      cancel-in-progress: true
+      group: ${{ github.workflow }}-build-probe-rs-${{ github.event.pull_request.number || github.ref }}
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Install target for cross-compilation
         run: rustup target add aarch64-unknown-linux-gnu
 
       - name: Install cross
-        uses: taiki-e/install-action@v2.79.0
+        uses: taiki-e/install-action@v2.87.29
         with:
           tool: cross
 
       - name: Cache Dependencies
-        uses: Swatinem/rust-cache@v2.9.1
+        uses: Swatinem/rust-cache@v2.9.2
 
       - name: Build probe-rs
-        run: cross build --release --target aarch64-unknown-linux-gnu -p probe-rs-tools --features remote
+        run: cross build --release --target aarch64-unknown-linux-gnu -p probe-rs-tools
 
       - uses: actions/upload-artifact@v7
         with:
@@ -73,10 +77,15 @@ jobs:
 
   test:
     runs-on: ["self-hosted", "linux", "ARM64", "${{ matrix.runner }}"]
+    # Do not cancel a running hardware job: that can leave the boards in a bad state.
+    # A new run of the same PR, branch, or tag waits for it.
+    concurrency:
+      cancel-in-progress: false
+      group: ${{ github.workflow }}-test-${{ matrix.runner }}-${{ github.event.pull_request.number || github.ref }}
     strategy:
       fail-fast: false
       matrix:
-        runner: ["smoke-test", "smoke-tester-2", "probe-rs-tester-0"]
+        runner: ["smoke-tester-2", "probe-rs-tester-0"]
 
     needs: build-smoke-tester
 
@@ -85,7 +94,7 @@ jobs:
 
     steps:
       - name: Checkout sources
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           # There is a conflict between the probe-rs/ subfolder and the probe-rs binary artifact, if the
           # checkout is done into the workspace root.
@@ -103,6 +112,11 @@ jobs:
 
   embedded-test:
     runs-on: ["self-hosted", "linux", "ARM64", "${{ matrix.runner }}"]
+    # Do not cancel a running hardware job: that can leave the boards in a bad state.
+    # A new run of the same PR, branch, or tag waits for it.
+    concurrency:
+      cancel-in-progress: false
+      group: ${{ github.workflow }}-embedded-test-${{ matrix.runner }}-${{ github.event.pull_request.number || github.ref }}
     strategy:
       matrix:
         runner: ["smoke-tester-2"]

.github/workflows/start-release.yml

@@ -17,7 +17,7 @@ jobs:
     env:
       BRANCH_NAME: create-release/${{ inputs.version }}
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
         with:
           # The custom token is needed so that this workflow can trigger
           # another workflow. By default, pushing tags from inside a workflow
@@ -61,7 +61,8 @@ jobs:
 
       - name: Bump versions
         run: |
-          cargo release version ${{ inputs.version }} --exclude probe-rs-mi --execute --verbose --no-confirm --allow-branch ${BRANCH_NAME}
+          # mi and rpc follow a separate versioning scheme
+          cargo release version ${{ inputs.version }} --exclude probe-rs-mi --exclude probe-rs-rpc --exclude probe-rs-rpc-client --execute --verbose --no-confirm --allow-branch ${BRANCH_NAME}
           cargo release replace --execute --verbose --no-confirm
           cargo release hook --execute --verbose --no-confirm
           cargo release commit --execute --verbose --no-confirm --sign-commit
@@ -98,6 +99,8 @@ jobs:
           - target-gen
           - probe-rs-tools
           - probe-rs-mi
+          - probe-rs-rpc
+          - probe-rs-rpc-client
           - probe-rs-debug"
         env:
           GH_TOKEN: ${{ secrets.GH_PAT }}