Skip to content

fix(s2n-quic-core): allow connection migration when the port scope changes #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanjoDeundiak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(s2n-quic-core): allow connection migration when the port scope changes #3166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions quic/s2n-quic-core/src/path/migration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,11 @@ pub mod default {
//# datagrams that match these patterns prior to validating the
//# destination address.

// NOTE: this may cause reachability issues if a peer or NAT use different
// port scopes for the same connection. Additional research may
// be required to determine if this countermeasure needs to be relaxed.
if PortScope::new(active_addr.port()) != PortScope::new(packet_addr.port()) {
let active_port_scope = PortScope::new(active_addr.port());
let packet_port_scope = PortScope::new(packet_addr.port());
if active_port_scope.is_system() != packet_port_scope.is_system() {
// Changing port scope from the system to a non-system (user or dynamic) scope
// and vice versa is rejected. Any other combination is allowed.
return Outcome::Deny(DenyReason::PortScopeChanged);
}

Expand Down Expand Up @@ -192,6 +193,11 @@ pub mod default {
49152..=65535 => Self::Dynamic,
}
}

#[inline]
pub fn is_system(&self) -> bool {
self == &PortScope::System
}
}

fn to_addr(addr: &SocketAddress) -> crate::inet::SocketAddress {
Expand Down
Loading