fix(s2n-quic-core): allow connection migration when the port scope changes - #3166
Open
SanjoDeundiak wants to merge 1 commit into
Open
fix(s2n-quic-core): allow connection migration when the port scope changes#3166SanjoDeundiak wants to merge 1 commit into
SanjoDeundiak wants to merge 1 commit into
Conversation
SanjoDeundiak
force-pushed
the
sanjo/port_scope_migration
branch
from
July 23, 2026 21:41
03cf308 to
2e08ef8
Compare
Contributor
|
Thanks for the contribution. I'd be more comfortable for now with leaving the System vs NonSystem distinction in place, though User<->Dynamic can be removed |
SanjoDeundiak
force-pushed
the
sanjo/port_scope_migration
branch
from
July 24, 2026 16:06
2e08ef8 to
7bd0c93
Compare
Author
|
Thanks @WesleyRosenblum. That sounds reasonable. I updated the PR |
SanjoDeundiak
force-pushed
the
sanjo/port_scope_migration
branch
from
July 24, 2026 23:02
7bd0c93 to
489a82a
Compare
Previously, any port scope change would result in rejected connection migration, which could cause unexpected reachability issues. To avoid that we now allow port scope change, unless it's system -> non-system scope change or vice versa.
SanjoDeundiak
force-pushed
the
sanjo/port_scope_migration
branch
from
August 7, 2026 19:18
489a82a to
05af535
Compare
Author
|
Hi @WesleyRosenblum, any updates on this one? |
Contributor
|
Sorry I missed this. Would you mind adding a test for this, there should be a natural spot in the connection migration integration test: https://github.com/aws/s2n-quic/blob/main/quic/s2n-quic-tests/src/tests/connection_migration.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #3040
Description of changes:
Currently server rejects the QUIC connection migration if the client port's scope has changed. It looks like the port scope change can normally happen during NAT rebinding, so I don't see why such migration attempt should be rejected. The QUIC RFC also has no suggestion to reject such migration.
Testing:
I don't think there was a test checking that migration is rejected when the port scope changes. Would be nice to have.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.