Skip to content

[#12975] fix(core): Preserve errors thrown by PrincipalUtils.doAs #12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerryshao merged 5 commits into from
Sep 10, 2026
Merged

[#12975] fix(core): Preserve errors thrown by PrincipalUtils.doAs #12976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9966cdb
[#12975] fix(core): Preserve errors thrown by PrincipalUtils.doAs
roryqi Sep 8, 2026
9f250eb
[#12975] test(server): Align with Error propagation
roryqi Sep 8, 2026
6b22c32
[#12975] fix(server): Preserve request error diagnostics in REST resp…
roryqi Sep 9, 2026
a28bc42
[#12975] fix(iceberg): Preserve request error diagnostics in REST res…
roryqi Sep 9, 2026
13e0eaa
[#12975] fix(lance): Preserve errors in REST responses
roryqi Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/org/apache/gravitino/utils/PrincipalUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public static <T> T doAs(Principal principal, PrivilegedExceptionAction<T> actio
Throwable cause = pae.getCause();
Throwables.propagateIfPossible(cause, Exception.class);
throw new RuntimeException("doAs method encountered an unexpected exception", pae);
} catch (Error t) {
LOG.warn("doAs method encountered an unexpected error", t);
throw new RuntimeException("doAs method encountered an unexpected exception", t);
} catch (Error error) {
LOG.warn("doAs method encountered an unexpected error", error);
throw error;

@jerryshao jerryshao Sep 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will be the exception when propogating to the client side?

@roryqi roryqi Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current behavior is the server will crash.

}
}

Expand Down
18 changes: 18 additions & 0 deletions core/src/test/java/org/apache/gravitino/utils/TestPrincipalUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,22 @@ public void testThread() throws Exception {
return null;
});
}

@Test
public void testErrorIsPropagated() {
UserPrincipal principal = new UserPrincipal("testErrorIsPropagated");
AssertionError error = new AssertionError("test error");

AssertionError thrown =
Assertions.assertThrows(
AssertionError.class,
() ->
PrincipalUtils.doAs(
principal,
() -> {
throw error;
}));

Assertions.assertSame(error, thrown);
}
}
Loading