[#12975] fix(core): Preserve errors thrown by PrincipalUtils.doAs - #12976
Open
roryqi wants to merge 2 commits into
Open
[#12975] fix(core): Preserve errors thrown by PrincipalUtils.doAs#12976roryqi wants to merge 2 commits into
roryqi wants to merge 2 commits into
Conversation
yuqi1129
previously approved these changes
Sep 8, 2026
jerryshao
reviewed
Sep 8, 2026
| throw new RuntimeException("doAs method encountered an unexpected exception", t); | ||
| } catch (Error error) { | ||
| LOG.warn("doAs method encountered an unexpected error", error); | ||
| throw error; |
Contributor
There was a problem hiding this comment.
What will be the exception when propogating to the client side?
Contributor
Author
There was a problem hiding this comment.
The current behavior is the server will crash.
Code Coverage Report
Files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rethrow the original
ErrorfromPrincipalUtils.doAsafter logging it,instead of wrapping it in a
RuntimeException.Add a unit test to verify that the original error instance is preserved.
Why are the changes needed?
Wrapping fatal JVM errors such as
OutOfMemoryErrorin aRuntimeExceptionchanges their classification and prevents callers anderror handlers from recognizing the actual failure.
Fix: #12975
Does this PR introduce any user-facing change?
Yes. Errors thrown by privileged actions retain their original type instead
of being exposed as
RuntimeException.How was this patch tested?
Ran:
./gradlew :core:spotlessApply :core:test --tests org.apache.gravitino.utils.TestPrincipalUtils