Repository navigation
[pipeline] Fix duplicated options for SfMBoostrapping and SfMExpanding - #2215
Merged
Merged
Conversation
cbentejac
approved these changes
Oct 20, 2026
cbentejac
force-pushed
the
dev/meshShortOption
branch
from
October 20, 2026 08:08
65bc2e3 to
5e4cf79
Compare
Contributor
|
Hi @pierre-wilmot, nice catch! Thanks for the fix. |
cbentejac
changed the title
SfMBoostrapping and SfMExpanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
main_sfmBootstrapping.cppandSfmExpanding.cppuse thetshort form option for both themeshFilenameandtracksFilenamearguments.Switched the
meshFilenameto usemas a short form.This didn't really show up as meshroom calls the binaries with the long form argument.
Features list
Implementation remarks