Repository navigation
Keep the web client off by default so GetUrl matches Windows (#214) - #215
Merged
Merged
Conversation
BC_WEBCLIENT=1 was in the tracked .env, so every CI run started the web client. That sets PublicWebBaseUrl to http://localhost:8080/, and GetUrl(ClientType::Web) is built from it: /BC/?company=X became http://localhost:8080/?company=X. The dev container now sets the variable itself. A boot with the web client off also clears the setting, because /bc/service is a volume and the old value would stay. Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214.
Commit 0262088 added
BC_WEBCLIENT=1to the tracked.env. Compose reads that file in every checkout, so since 2026-10-28 CI and consumer workflows have started the web client. It setsPublicWebBaseUrltohttp://localhost:8080/, andGetUrl(ClientType::Web, ...)is built from that setting.Changes
BC_WEBCLIENT=1from.env. The web client is opt-in again, as the docs say.BC_WEBCLIENT=1incontainerEnvindevcontainer.json, so Codespaces still start it.entrypoint.shclearsPublicWebBaseUrlon a boot with the web client off./bc/serviceis a volume, so the old value stayed on a warm volume.Testing
BC 27.5, the new test codeunit on its own in a scratch app, one stack and one volume:
BC_WEBCLIENTPublicWebBaseUrlhttp://localhost:8080/http://localhost:8080/?page=21I did not start a Codespace, so the
containerEnvchange is untested. I also did not run the corpus tests.Local
docker compose upno longer starts the web client unlessBC_WEBCLIENT=1is set.https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD