Skip to content

Keep the web client off by default so GetUrl matches Windows (#214) - #215

Merged
StefanMaron merged 1 commit into
masterfrom
fix-geturl-web-client-env-214
Nov 3, 2026
Merged

StefanMaron merged 1 commit into
masterfrom
fix-geturl-web-client-env-214

Conversation

@StefanMaron

Copy link
Copy Markdown
Collaborator

Fixes #214.

Commit 0262088 added BC_WEBCLIENT=1 to the tracked .env. Compose reads that file in every checkout, so since 2026-10-28 CI and consumer workflows have started the web client. It sets PublicWebBaseUrl to http://localhost:8080/, and GetUrl(ClientType::Web, ...) is built from that setting.

Changes

  • Removed BC_WEBCLIENT=1 from .env. The web client is opt-in again, as the docs say.
  • Set BC_WEBCLIENT=1 in containerEnv in devcontainer.json, so Codespaces still start it.
  • entrypoint.sh clears PublicWebBaseUrl on a boot with the web client off. /bc/service is a volume, so the old value stayed on a warm volume.
  • Added smoke codeunit 70079 to the version matrix on all BC versions.

Testing

BC 27.5, the new test codeunit on its own in a scratch app, one stack and one volume:

BC_WEBCLIENT PublicWebBaseUrl Tests
1 http://localhost:8080/ 3 failed, for example http://localhost:8080/?page=21
0 (same volume) empty 3 passed

I did not start a Codespace, so the containerEnv change is untested. I also did not run the corpus tests.

Local docker compose up no longer starts the web client unless BC_WEBCLIENT=1 is set.

https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD

BC_WEBCLIENT=1 was in the tracked .env, so every CI run started the web
client. That sets PublicWebBaseUrl to http://localhost:8080/, and
GetUrl(ClientType::Web) is built from it: /BC/?company=X became
http://localhost:8080/?company=X.

The dev container now sets the variable itself. A boot with the web
client off also clears the setting, because /bc/service is a volume and
the old value would stay.

Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
@StefanMaron
StefanMaron merged commit 79d557f into master Nov 3, 2026
40 of 41 checks passed
@StefanMaron
StefanMaron deleted the fix-geturl-web-client-env-214 branch November 3, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetUrl for the web client drops the slash before ?company= with the 5bd6cab2 images (Windows and 65f6b26 keep it)

1 participant