You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
GetUrl for the web client drops the slash before ?company= with the 5bd6cab2 images (Windows and 65f6b26 keep it) #214
With the images built from 5bd6cab, GetUrl(ClientType::Web, ...) returns the web client URL without the slash before the query string. With the images from 65f6b26 and on Windows, the slash is there.
The same happens with &page=, &filter= and &bookmark= added. The corpus tests are in aldevtools/BusinessCentral.AL.Language.Tests, codeunit 69381 (GetUrl_ClientWeb, GetUrl_Web_CompanyCharacters, GetUrl_Web_FilterCharacters, GetUrl_Web_ReportQueryCodeunitWithRecord, GetUrl_Web_BookmarkOfCodeKeys).
A second difference, from the same run: the Windows Language table (Windows Language, codeunit 92150 Y21_WindowsLanguage_Flags) has 214 rows with images 5bd6cab and 208 with 65f6b26, but 248 on Windows BC 27.5 and 28.5. I'm not sure the row count can match Windows exactly, because Windows takes it from the OS cultures. I'm reporting it here so you can decide whether it is in scope; the corpus will stop asserting the exact count.
Correction: this comes from the workflow and scripts, not from the images. The corpus PR aldevtools/BusinessCentral.AL.Language.Tests#1096 pins only the workflow and bc_linux_ref to 622646e and keeps the runner images at 65f6b26. The slash is gone there too on BC 27.5, for example:
QA_GetUrl_Web_NoArgument_Whole: the path part of the URL differs as well
So something between 65f6b26 and 622646e in the scripts that configure the service tier (the web base URL setting, for example) changed the URL. Windows still has the slash.
The correction above was right: this came from the checkout, not the image. BC_WEBCLIENT=1 was added to the tracked .env on 2026-10-28, so Compose started the web client in every CI run. The web client sets PublicWebBaseUrl to http://localhost:8080/, and GetUrl builds the web URL from that setting. The URL was therefore http://localhost:8080/?company=X, and the /BC path was gone. That is also why your Base() helper saw ?company= as the rest of the URL.
To pick this up, pin bc_linux_ref to the commit above. The .env change alone fixes CI, so the runner images can stay as they are.
Smoke codeunit 70079 now guards the URL on every BC version in the matrix, and it passes on all of them. I did not run corpus codeunit 69381. Please reopen if those tests still fail.
Windows Language row count: I did not change this. Rows went from 208 to 214 because of #198. Windows has 248 because it reads the list from the operating system's cultures. To match it, I need the actual Windows row list, because we only add Windows data that was measured there. A count does not show which 34 rows are missing. If the corpus can export the language IDs from a Windows run, please open a new issue with that list and I can add them.
Activity
StefanMaron commentedon Nov 3, 2026
Correction: this comes from the workflow and scripts, not from the images. The corpus PR aldevtools/BusinessCentral.AL.Language.Tests#1096 pins only the workflow and
bc_linux_refto 622646e and keeps the runner images at 65f6b26. The slash is gone there too on BC 27.5, for example:GetUrl_Web_ObjectTypesAndIds: expected<base>/?page=21, got<base>?page=21GetUrl_Web_CurrentCompanyShape: expectedrest_prefix = /?company, got?company=QA_GetUrl_Web_NoArgument_Whole: the path part of the URL differs as wellSo something between 65f6b26 and 622646e in the scripts that configure the service tier (the web base URL setting, for example) changed the URL. Windows still has the slash.
Keep the web client off by default so GetUrl matches Windows (#214) (#…
StefanMaron commentedon Nov 3, 2026
Fixed on master by #215, commit 79d557f.
The correction above was right: this came from the checkout, not the image.
BC_WEBCLIENT=1was added to the tracked.envon 2026-10-28, so Compose started the web client in every CI run. The web client setsPublicWebBaseUrltohttp://localhost:8080/, andGetUrlbuilds the web URL from that setting. The URL was thereforehttp://localhost:8080/?company=X, and the/BCpath was gone. That is also why yourBase()helper saw?company=as the rest of the URL.To pick this up, pin
bc_linux_refto the commit above. The.envchange alone fixes CI, so the runner images can stay as they are.Smoke codeunit 70079 now guards the URL on every BC version in the matrix, and it passes on all of them. I did not run corpus codeunit 69381. Please reopen if those tests still fail.
Windows Language row count: I did not change this. Rows went from 208 to 214 because of #198. Windows has 248 because it reads the list from the operating system's cultures. To match it, I need the actual Windows row list, because we only add Windows data that was measured there. A count does not show which 34 rows are missing. If the corpus can export the language IDs from a Windows run, please open a new issue with that list and I can add them.